WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#31889 closed defect (bug) (fixed)

Customizer Theme Switcher: Section will be deactivated if search result is empty

Reported by: ocean90's profile ocean90 Owned by: ocean90's profile ocean90
Milestone: 4.2 Priority: high
Severity: normal Version: 4.2
Component: Customize Keywords: has-patch
Focuses: javascript Cc:

Description

Before #31837 we had a control per theme (can be deactivated if it doesn't match a search term) and the add-new control (was always active). But now all controls can be deactivated which makes isContextuallyActive returning false. The result of this is an empty sidebar.

Attachments (2)

31889.png​ (22.6 KB) - added by ocean90 10 years ago.
31889.diff​ (711 bytes) - added by westonruter 10 years ago.
​https://github.com/xwp/wordpress-develop/pull/84

Download all attachments as: .zip

Change History (5)

@ocean90
10 years ago

#1 @westonruter
10 years ago

  • Owner set to westonruter
  • Status changed from new to assigned

@westonruter
10 years ago

​https://github.com/xwp/wordpress-develop/pull/84

#2 @westonruter
10 years ago

  • Focuses javascript added
  • Keywords has-patch added; needs-patch removed
  • Owner changed from westonruter to ocean90
  • Status changed from assigned to reviewing

See 31889.diff​ which overrides the isContextuallyActive method to ignore the theme controls' active states.

#3 @ocean90
10 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 32083:

Customizer Theme Switcher: Don't deactivate section on empty search results.

props westonruter.
fixes #31889.

Note: See TracTickets for help on using tickets.