WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 3 years ago

#31893 closed defect (bug) (fixed)

include '//' in emoji url.

Reported by: tmatsuur's profile tmatsuur Owned by: pento's profile pento
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: General Keywords:
Focuses: javascript Cc:

Description

Posts containing the Emoji I was displayed in Chrome on Windows 8.1.
Emoji have been rewritten to img element, were included '' in the URL of the img element.

Example: beer
​http://s.w.org/images/core/emoji/72x72//1f37a.png

I think that the 72x72// is good in 72x72/.

head element[page source]:

window._wpemojiSettings = {"baseUrl":"http:\/\/s.w.org\/images\/core\/emoji\/72x72\/","ext":".png", ...

twemoji.parse[wp-emoji.js]: line130

return ''.concat( options.base, '/', icon, options.ext );

I think that it should do fixed in such a feeling.

return ''.concat( options.base, icon, options.ext );

Change History (3)

#1 @pento
9 years ago

  • Focuses javascript added
  • Milestone changed from Awaiting Review to 4.2
  • Owner set to pento
  • Status changed from new to assigned

#2 @pento
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32024:

Emoji: Remove an errant / in Twemoji URLs.

Props tmatsuur.

Fixes #31893.

This ticket was mentioned in ​Slack in #core-editor by colorful-tones. ​View the logs.
3 years ago

Note: See TracTickets for help on using tickets.