![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#31908 closed defect (bug) (fixed)
Insert into post button runs off the side of the screen on small devices
| Reported by: | ryan | Owned by: | helen |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.2 |
| Component: | Media | Version: | 4.1 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | ui |
Description
The insert into post button in the media modal runs off the side of the screen on iPhone 5 and Nexus 5.
4.2-beta4-31998-src
Attachments (4)
Change History (19)
#1
@
11 years ago
- Summary Insert into post button runs off the side off the screen on small devices → Insert into post button runs off the side of the screen on small devices
#5
@
11 years ago
My question here: Why is .search-form being added to every view? That seems to be what the max-width was targeting in the first blame (at least what I gather from the commit message in r30813). I think a proper fix with focus on getting .search-form added only where it needs to be and moving max-width to a more targeted selector.
This ticket was mentioned in Slack in #core by drew. View the logs.
11 years ago
#9
@
11 years ago
- Keywords commit removed
Too broad of a change, not good on wider screens with many attachments selected. Will look at this more holistically after #30725, which is making changes in the same vicinity so I'd prefer to avoid a conflict there since it's a more complicated patch.
#10
@
11 years ago
- Keywords punt added
We need to make a decision here, punt or fix. I'm fine with punting as this isn't new to 4.2.
This ticket was mentioned in Slack in #core by drew. View the logs.
11 years ago
#12
@
11 years ago
31908.2.patch looks good. The problem comes from both "area containers" having the same class name: media-toolbar, and the same "sub-containers" class names. We need to limit them (max-width) for the "toolbar" above the attachments listing area. There's no need to limit them when used under the attachments listing, where the "Insert into post" button is.
Introduced in [30813], see #30658.