WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3191 closed enhancement (fixed)

Inline Uploading interface improvements

Reported by: mdawaffe Owned by: mdawaffe
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.1
Component: Administration Keywords: JS
Focuses: Cc:

Description

Initial run.

  1. Accesss uploaded files through Manage -> Uploads.
  2. svn mv wp-admin/inline-uploading.php wp-admin/upload.php.
  3. Clearer "Send to editor" options.
  4. Fully pluggable tabs.
  5. Cacheable JS and CSS.
  6. Can edit file titles and descriptions.
  7. JS has random version string for debugging.

To Do:

  1. Split tabs into This Post / Images / Files ?
  2. UI/Layout improvements?

Attachments (13)

3191.diff (78.0 KB) - added by mdawaffe 9 years ago.
3191b.diff (33.0 KB) - added by mdawaffe 9 years ago.
Bold?.png (7.3 KB) - added by mdawaffe 9 years ago.
bold labels?
Picture 3.png (6.9 KB) - added by mdawaffe 9 years ago.
Picture 4.png (6.7 KB) - added by mdawaffe 9 years ago.
Picture 4.2.png (6.5 KB) - added by mdawaffe 9 years ago.
Picture 5.png (32.9 KB) - added by mdawaffe 9 years ago.
Picture 6.png (33.3 KB) - added by mdawaffe 9 years ago.
3191c.diff (13.3 KB) - added by mdawaffe 9 years ago.
CSS and layout improvements
3191d.diff (6.2 KB) - added by mdawaffe 9 years ago.
don't include admin-header for inline
3191e.diff (3.6 KB) - added by mdawaffe 9 years ago.
more bugs
Picture 7.png (39.4 KB) - added by mdawaffe 9 years ago.
3191e.2.diff (13.4 KB) - added by mdawaffe 9 years ago.
This is sucking out my will to live

Download all attachments as: .zip

Change History (27)

@mdawaffe
9 years ago

#1 @mdawaffe
9 years ago

  • Owner changed from anonymous to mdawaffe
  • Status changed from new to assigned

#2 @markjaquith
9 years ago

Patch isn't applying correctly...

/wp-admin/upload.php doesn't exist in trunk...

#3 @mdawaffe
9 years ago

I shouldn't have svn moved. Didn't think of that, sorry.

svn mv wp-admin/inline-uploading.php wp-admin/upload.php on your local copy first, then try applying the patch. Hopefully that will work.

Further To Do:

  1. pagination. #3159 would help.

#4 @markjaquith
9 years ago

Nah, that doesn't work, because the patch tries to put code into both inline-uploading.php and upload.php

@mdawaffe
9 years ago

#5 @mdawaffe
9 years ago

Why there is no svn patch is a mystery to me.

Try this: 3191b.diff

#6 @ryan
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4274]) Uploader improvements from mdawaffe. fixes #3191

#7 @Nazgul
9 years ago

Does this also fix #3173? I don't have Opera available here to test it.

#8 @foolswisdom
9 years ago

mdawaffe updated ticket:3173 suggesting it does. Thanks Nazgul.

@mdawaffe
9 years ago

bold labels?

@mdawaffe
9 years ago

@mdawaffe
9 years ago

@mdawaffe
9 years ago

@mdawaffe
9 years ago

@mdawaffe
9 years ago

@mdawaffe
9 years ago

CSS and layout improvements

#9 @ryan
9 years ago

(In [4312]) Uploader improvements from mdawaffe. fixes #3191

@mdawaffe
9 years ago

don't include admin-header for inline

#10 @mdawaffe
9 years ago

3191d.diff

  1. Don't include admin-header.php for inline.
  2. Some bugs fixed when going between JS and no JS.
  3. Thumbnail list items sohuld link to edit in Manage->Uploads.

#11 @ryan
9 years ago

(In [4340]) Uploader improvements from mdawaffe. fixes #3191

@mdawaffe
9 years ago

more bugs

@mdawaffe
9 years ago

@mdawaffe
9 years ago

This is sucking out my will to live

#12 @mdawaffe
9 years ago

Do nothing with 3191e.diff

Commit 3191e.2.diff

#13 @Nazgul
9 years ago

mdawaffe, could you take a look at #899 and see if it can be combined with this one?

(and why are you attaching new patches to a closed ticket? shouldn't it be reopened then?)

#14 @mdawaffe
9 years ago

Nazgul - no good reason to keep flooding this closed ticket :)

And I've closed #899

Note: See TracTickets for help on using tickets.