WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#31912 closed defect (bug) (fixed)

Media splitting: don't copy the media folder to the build directory

Reported by: iseulde Owned by: wonderboymusic
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Build/Test Tools Keywords: has-patch
Focuses: javascript Cc:

Description

These are not used when SCRIPT_DEBUG is on.

Attachments (2)

31912.patch (649.8 KB) - added by iseulde 4 years ago.
31912.2.patch (5.3 KB) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (10)

@iseulde
4 years ago

#1 @iseulde
4 years ago

  • Keywords has-patch added

Maybe better to keep the old file structure? Not sure. Makes the tasks a bit simpler as well.

#2 @netweb
4 years ago

  • Component changed from Media to Build/Test Tools
  • Focuses javascript added

Moving this ticket also to the Build Tools component as I did for #31911, these tickets are more about how we build and compile assets rather than the media component functionality :)

#3 follow-up: @iseulde
4 years ago

Cool, sorry. :)

#4 in reply to: ↑ 3 @netweb
4 years ago

Replying to iseulde:

Cool, sorry. :)

Apologies not required :)

#5 @DrewAPicture
4 years ago

  • Owner set to wonderboymusic
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core by drew. View the logs.


4 years ago

@ocean90
4 years ago

#7 @ocean90
4 years ago

We won't delete the files, rather copy/move the existing ones so the history remains. Based on the patch this seems to be the follow changes:

  • /src/wp-includes/js/media/audio-video.manifest.js => /src/wp-includes/js/media/audiovideo.manifest.js
  • /src/wp-includes/js/media/audio-video.js => /src/wp-includes/js/media-audiovideo.js
  • /src/wp-includes/js/media/grid.js => /src/wp-includes/js/media-grid.js
  • /src/wp-includes/js/media/models.js => /src/wp-includes/js/media-models.js
  • /src/wp-includes/js/media/views.js => /src/wp-includes/js/media-views.js

31912.2.patch includes only the changes for the build task and the script loader.

#8 @wonderboymusic
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32125:

Move the built media JS files up a directory to their previous location and naming convention. This fidgets with part of [31373] and will maintain BC for those who were loading those files directly (not using the enqueue system).

Props iseulde, ocean90.
Fixes #31912.

Note: See TracTickets for help on using tickets.