![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 11 years ago
Closed 4 years ago
#31914 closed defect (bug) (wontfix)
Remove static variable for global_terms_enable to allow for unit tests
| Reported by: | jeremyfelt | Owned by: | jeremyfelt |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Taxonomy | Version: | 3.0 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | multisite |
Description
From @boonebgorges in #31149:
global_terms_enabled() stores the check in a static, which makes it impossible to toggle for the purposes of the unit tests. This was introduced in [14344] in what was, I assume, an attempt to optimize the function. @nacin do you have a problem if I roll this back and filter it every time the function is called? global_terms_enabled() is not called anywhere on the front end in core, and nowhere that I've found yet in the plugin repo, so I don't foresee any serious performance issues.
31149.diff makes the necessary changes and adds unit tests to address #31149
Change History (7)
This ticket was mentioned in Slack in #core by helen. View the logs.
11 years ago
#5
@
11 years ago
- Keywords has-patch, dev-feedback → has-patch dev-feedback
- Milestone 4.3 → Future Release
No movement in 4.3, maybe in a future release.
#6
@
11 years ago
What do we need here - a consult from somebody with knowledge of the history or an eye on the implications of this?
#7
@
4 years ago
- Keywords dev-feedback removed
- Resolution → wontfix
- Status assigned → closed
Global terms has officially been deprecated and no-opped in [54240]. As I understand it, this is a suggestion to modify the contents of global_terms_enabled(), so I'm closing this as a won't fix.
In 32064: