Opened 6 years ago
Last modified 20 months ago
#31914 assigned defect (bug)
Remove static variable for global_terms_enable to allow for unit tests
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.0 |
Component: | Taxonomy | Keywords: | has-patch dev-feedback |
Focuses: | multisite | Cc: |
Description
From @boonebgorges in #31149:
global_terms_enabled() stores the check in a static, which makes it impossible to toggle for the purposes of the unit tests. This was introduced in [14344] in what was, I assume, an attempt to optimize the function. @nacin do you have a problem if I roll this back and filter it every time the function is called? global_terms_enabled() is not called anywhere on the front end in core, and nowhere that I've found yet in the plugin repo, so I don't foresee any serious performance issues.
31149.diff makes the necessary changes and adds unit tests to address #31149
Change History (6)
Note: See
TracTickets for help on using
tickets.
In 32064: