WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#31922 closed defect (bug) (fixed)

FS credentials dialog: Placeholder for hostname isn't translatable

Reported by: ocean90 Owned by: jorbin
Milestone: 4.2 Priority: normal
Severity: minor Version: 4.2
Component: Filesystem API Keywords: has-patch
Focuses: ui Cc:
PR Number:

Description

See trunk/src/wp-admin/includes/file.php@31949#L1151, in esc_attr_e( __( 'example: www.mysite.com' ) ) the __() is too much.

I would also like to see another domain which is used as an example. Brainstorming with @drew: example.org, wordpress.org or gnu.org.

Attachments (1)

31922-hostname-placeholder.diff (984 bytes) - added by Tmeister 5 years ago.

Download all attachments as: .zip

Change History (9)

#1 @Tmeister
5 years ago

  • Keywords has-patch added; needs-patch removed

Removed __() and domain name changed!

#2 @jorbin
5 years ago

  • Owner set to jorbin
  • Status changed from new to reviewing

#3 @jorbin
5 years ago

Since it includes the english word "example", shouldn't its still be translated? I'm thinking:
print_f( __( "example: %s"), 'www.wordpress.org' );

#4 @jeremyfelt
5 years ago

esc_attr_e() is handling the translation, so the __() isn't needed. +1 on using wordpress.org.

#5 @jorbin
5 years ago

Totally didn't read the _e on the function name.

#6 @jorbin
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 32077:

Update placeholder for FTP credentials

Two changes:

  • Remove superfluous function call
  • Update domain used

Fixes #31922
Props Tmeister

#7 @nacin
5 years ago

Maybe we could remove the www here? :-) It'd be a string change, so 4.3.

#8 @johnbillion
5 years ago

Why aren't we using the current hostname in the example like we do everywhere else?

Note: See TracTickets for help on using tickets.