#31922 closed defect (bug) (fixed)
FS credentials dialog: Placeholder for hostname isn't translatable
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.2 | Priority: | normal |
| Severity: | minor | Version: | 4.2 |
| Component: | Filesystem API | Keywords: | has-patch |
| Focuses: | ui | Cc: |
Description
See trunk/src/wp-admin/includes/file.php@31949#L1151, in esc_attr_e( __( 'example: www.mysite.com' ) ) the __() is too much.
I would also like to see another domain which is used as an example. Brainstorming with @drew: example.org, wordpress.org or gnu.org.
Attachments (1)
Change History (10)
#3
@
11 years ago
Since it includes the english word "example", shouldn't its still be translated? I'm thinking:
print_f( __( "example: %s"), 'www.wordpress.org' );
#4
@
11 years ago
esc_attr_e() is handling the translation, so the __() isn't needed. +1 on using wordpress.org.
#8
@
11 years ago
Why aren't we using the current hostname in the example like we do everywhere else?
This ticket was mentioned in PR #11563 on WordPress/wordpress-develop by @dmsnell.
10 hours ago
#9
Trac ticket: Core-31922
Scaffolding an idea to progressively enhance WordPress for allowing non-US-ASCII (“Unicode”) email addresses.
Removed
__()and domain name changed!