WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#31923 closed defect (bug) (fixed)

Press This: show a notice on successful saving

Reported by: azaozz Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Press This Keywords:
Focuses: Cc:

Description

Currently there is no confirmation that a post has been saved successfully. The spinner disappears but... Leaves a lingering doubt... :)

Attachments (2)

31923.patch (2.6 KB) - added by azaozz 4 years ago.
31923.2.patch (5.8 KB) - added by azaozz 4 years ago.

Download all attachments as: .zip

Change History (12)

#1 @azaozz
4 years ago

Caused by no longer redirecting on saving a draft. Also need to include an Edit link that opens the post for editing in the "main" editor.

@azaozz
4 years ago

#2 @azaozz
4 years ago

In 31923.patch: show a notice including an "Edit" link that opens the post on the Edit Post screen in the main window. Needs better text / names :)

@azaozz
4 years ago

#3 @azaozz
4 years ago

In 31923.2.patch, as discussed in #core-pressthis:

  • Instead of a notice on saving a draft, change the text of the Save Draft button to "Saving...".
  • On success, hide the button and show "Edit Post" link in its place. If the user focuses the title or the editor, hide the link and show the button again.

#4 @ryan
4 years ago

With 31923.2.patch on an iPhone 6+, focusing and even typing in the editor doesn't change Edit post back to Save Draft. Focusing the title does change Edit post back to Save Draft. Also, "Edit post" and "Save Draft" don't follow the same capitalization rules.

Unsure about Save Draft becoming Edit post. My first reaction was of the huh? variety. Aren't I already editing the post? Opening post-new.php in a new window is so disorienting on mobile.

#5 @DrewAPicture
4 years ago

  • Owner set to azaozz
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #core by drew. View the logs.


4 years ago

#7 @azaozz
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 32092:

Press This:

  • When saving a draft change the text of the Save Draft button to Saving...
  • On success, hide the button and show Edit Post link in its place. If the user focuses the title or the editor, hide the link and show the button again.

Fixes #31923.

#8 @azaozz
4 years ago

In 32093:

Press This: change the link text to Standard Editor.
Props Michael-Arestad. See #31923.

#9 @stephdau
4 years ago

Yay! :)

#10 @azaozz
4 years ago

In 32098:

Press This:

  • Fix focusing the Standard Editor link after saving draft, if the user has not focused another element.
  • Reset the Save Draft button on node change in the editor.

See #31923.

Note: See TracTickets for help on using tickets.