Opened 10 years ago
Closed 9 years ago
#31927 closed defect (bug) (fixed)
Words in a sentence should not be capitalised after a comma
Reported by: | netweb | Owned by: | netweb |
---|---|---|---|
Milestone: | 4.3 | Priority: | low |
Severity: | normal | Version: | 3.1 |
Component: | Text Changes | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Various instances of this are thoughout core:
No, Return me to the plugin list
Yes, Delete these files and data
Yes, Delete these files
Yes, Delete this theme
Replying to ocean90:
Replying to netweb:
Via @bjornjohansen in #polglots on Slack https://wordpress.slack.com/archives/polyglots/p1428177381000724
Please create a new ticket for this. The string was introduced in [17101] and we have some similar strings too:
- No, Return me to the plugin list
- Yes, Delete these files and data
- Yes, Delete these files
(https://wordpress.slack.com/archives/polyglots/p1428398252000768)
Attached patch fixes the 6 instances of these 4 strings.
Props to bjornjohansen please :)
Attachments (2)
Change History (14)
#2
@
10 years ago
- Keywords 4.3-early added; i18n-change removed
- Milestone changed from 4.2 to Future Release
#3
@
10 years ago
- Keywords has-patch removed
Also pick up the the couple of capitalisation strings held over from #31921
printf( _n( '%1$s Response to %2$s', '%1$s Responses to %2$s', get_comments_number() ),
__( 'One Response to %s' ),
#6
@
10 years ago
- Component changed from I18N to Text Changes
- Summary changed from i18n: Words in a sentence should not be capitalised after a comma to Words in a sentence should not be capitalised after a comma
#7
follow-up:
↓ 9
@
10 years ago
- Keywords needs-patch added
I'm happy to take this on as my first attempt to contribute to core after years of doing development on top of WP.
That said, this ticket should probably provide guidance on whether it should only address user-facing text or other instances in the source where it occurs (i.e. comments). I just did a pretty primitive grep on trunk and found a number of issues and inconsistencies, e.g.
// This Class uses the timeout on a per-connection basis, Others use it on a per-action basis. // Nothing, This will be displayed within a iframe. //Download the package (Note, This just returns the filename of the file if the package is a local file) // Boom, This sites about to get a whole new splash of paint! * Theme Upgrader class for WordPress Themes, It is designed to upgrade/install themes from a local zip, remote zip URL, or uploaded zip file.
(the last line has additional grammatical errors as well)
Actually, upon further review, it looks like the comments could use a lot more cleanup than just capitalization after a comma. Is there an official style guide? Spaces after double slashes, American vs. International spelling, etc all seem a tad... inconsistent.
This ticket was mentioned in Slack in #core by ocean90. View the logs.
10 years ago
#9
in reply to:
↑ 7
@
9 years ago
Replying to drywallbmb:
I'm happy to take this on as my first attempt to contribute to core after years of doing development on top of WP.
Excellent, thanks
That said, this ticket should probably provide guidance on whether it should only address user-facing text or other instances in the source where it occurs (i.e. comments). I just did a pretty primitive grep on trunk and found a number of issues and inconsistencies
Let's just fix the code side in this ticket, the comments/docs inconsistencies will be addressed via the docs team or updated on a case by case basis as the code surrounding those comments/docs is updated.
To quote, or paraphrase a quote around here somewhere that I cannot find ;)
Code refactoring should not be done just because we can
#10
follow-up:
↓ 11
@
9 years ago
@netweb, is your patch complete or does it need to cover other parts of WP too?
#11
in reply to:
↑ 10
@
9 years ago
- Keywords has-patch commit added; needs-patch removed
Replying to obenland:
@netweb, is your patch complete or does it need to cover other parts of WP too?
Yes, 31927.2.diff is now complete :)
Per the original description for props also please, Props to bjornjohansen, netweb
would be great :)
We're already in string freeze.