WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#31934 closed defect (bug) (fixed)

Twenty Fifteen: Images in the editor still overflow in some cases

Reported by: iamtakashi Owned by: lancewillett
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Since [31849], the images in the editor are better in small screens but the change doesn't seem to take account the margin in the editor: 40px on each side. Therefore when the editor is say, 668px wide, an image overflows. I think the max-width for the media query should be 740px (660 + 40 + 40)px.

Before: (Note the horizontal scroll bar and the box model view)

https://cldup.com/E1ixFSV518.png

After:

https://cldup.com/51Xic104Sy.png

Related: #31250, #31253

Attachments (2)

31934.diff (466 bytes) - added by iamtakashi 4 years ago.
31934.1.diff (470 bytes) - added by iamtakashi 4 years ago.
For Twenty Fourteen.

Download all attachments as: .zip

Change History (10)

@iamtakashi
4 years ago

#1 @iamtakashi
4 years ago

  • Summary changed from Twenty Fifteen: Images in the editor still overflows in some cases to Twenty Fifteen: Images in the editor still overflow in some cases

#2 @lancewillett
4 years ago

  • Milestone changed from Awaiting Review to 4.2
  • Version set to trunk

#3 @iamtakashi
4 years ago

If this looks good to go I'll make a patch for Twenty Fourteen too.

#4 @lancewillett
4 years ago

Good to go from looking at the patch in terms of the CSS itself, just testing a bit more for the breakpoint.

#5 @lancewillett
4 years ago

Looks good in testing.

#6 @lancewillett
4 years ago

In 32090:

Twenty Fifteen: update editor styles to better account for adaptive images in small screens.

See #31934, props iamtakashi.

#7 @lancewillett
4 years ago

@iamtakashi Feel free to put Twenty Fourteen patch here on the same ticket if you want to.

@iamtakashi
4 years ago

For Twenty Fourteen.

#8 @lancewillett
4 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 32094:

Twenty Fourteen: update editor styles to better account for adaptive images in small screens.

Fixes #31934, props iamtakashi.

Note: See TracTickets for help on using tickets.