WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 11 months ago

#31938 closed defect (bug) (fixed)

Apply script_loader_src filters to emoji JavaScript files

Reported by: peterwilsoncc Owned by: pento
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: General Keywords: has-patch
Focuses: javascript Cc:
PR Number:

Description

Apply the script_loader_src filter to the emoji JavaScript files:

  • wp-includes/js/wp-emoji.js
  • wp-includes/js/twemoji.js
  • wp-includes/js/wp-emoji-loader.js

For use with CDNs, etc.

Please advise if this is not the best filter and I will supply a new patch.

Attachments (1)

31938.1.patch (988 bytes) - added by peterwilsoncc 5 years ago.

Download all attachments as: .zip

Change History (5)

#1 @peterwilsoncc
5 years ago

  • Type changed from defect (bug) to enhancement

#2 @pento
5 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.2
  • Owner set to pento
  • Status changed from new to assigned
  • Type changed from enhancement to defect (bug)

Agreed, these URLs should be filtered.

#3 @pento
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32097:

Emoji: The emoji JS files should be run through the script_loader_src filter, as they would be if they were registered scripts.

Props peterwilsoncc.

Fixes #31938.

This ticket was mentioned in Slack in #core by bartczyz. View the logs.


11 months ago

Note: See TracTickets for help on using tickets.