WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#31953 closed defect (bug) (fixed)

'Cockney' filter needs to be translated

Reported by: yoavf Owned by: miqrogroove
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: Formatting Keywords: wptexturize has-patch
Focuses: Cc:
PR Number:

Description

In languages such as Gaelic (gd), when an apostrophe is used as an initial word character, it must be a left-curling apostrophe, not a right curling one.

Example:
'gam

Should be
’gam

But WP currently turns it in
‘gam

This is similar to #29813 but in this case this isn't an exception for a cockney, but a rule for a language (and probably other languages too).

Attachments (2)

miqro-31953.diff (2.1 KB) - added by miqrogroove 4 years ago.
miqro-31953.2.diff (2.4 KB) - added by miqrogroove 4 years ago.
More description for translators.

Download all attachments as: .zip

Change History (18)

#1 @miqrogroove
5 years ago

  • Keywords wptexturize reporter-feedback added
  • Summary changed from wptexturize: opening single quote instead of apostrophe when used as initial word character to Gaelic opening single quote instead of apostrophe

Hi yoavf, there is not enough information here. Does Gaelic use single quotes in other contexts? Are apostrophes before a word never considered a quotation in Gaelic? Does Gaelic use apostrophes in other positions?

#2 follow-up: @akerbeltzalba
4 years ago

Quotes are both word characters and punctuation in Gaelic. So the Gaelic equivalent to
He said ‘Oh my goodness’
would become
Thuirt e ‘O mo chreach’

But in a phrase such as
Tha e ’gam bhualadh
it is a word character.

So I don't think it is possible to automatically code for this unless it is possible to specify a (finite) list of words with initial ’ as a word character. Which is why I asked it it was possible to switch off the auto-format of the first instance of ' to ‘ because that may not always be right in Gaelic.

#3 in reply to: ↑ 2 ; follow-up: @miqrogroove
4 years ago

Replying to akerbeltzalba:

So I don't think it is possible to automatically code for this unless it is possible to specify a (finite) list of words with initial ’ as a word character.

The name for this feature in WP is "cockney". The default values are English-only. The $wp_cockneyreplace global variable replaces the defaults when provided. This might be the thing you are looking for.

#4 in reply to: ↑ 3 ; follow-up: @akerbeltzalba
4 years ago

Replying to miqrogroove:

The name for this feature in WP is "cockney". The default values are English-only. The $wp_cockneyreplace global variable replaces the defaults when provided. This might be the thing you are looking for.

I'm not entirely sure what this feature forces in terms of behaviour? Would it result in something like
“Thuirt e a thighinn ’gam bhualadh”
and
‘mar gum biodh tu ’gam faicinn’
and
Thuirt e a thighinn ’gam bhualadh
and
Bha e ‘mar gum biodh’ fasanta

If so, then that would fix the problem provided that it could be made the default behaviour for WP.com and WP.org when a user downloads or selects gd as a locale.

The naming of this feature also grates, as Gaelic isn't really a cockney. Could this be re-labelled something like wp_singleleftquotereplace?

#5 in reply to: ↑ 4 @miqrogroove
4 years ago

Replying to akerbeltzalba:

Would it result in something like
“Thuirt e a thighinn ’gam bhualadh”

Yes. Now, we just need to figure out if the ticket should remain open? And since there is no bug here for Formatting, should it be assigned to I18N component?

#6 @akerbeltzalba
4 years ago

Now, we just need to figure out if the ticket should remain open?
And since there is no bug here for Formatting, should it be assigned to I18N component?

I'm ok with whatever gets use the desired result for our locale.

This ticket was mentioned in Slack in #core-i18n by miqrogroove. View the logs.


4 years ago

#8 @miqrogroove
4 years ago

  • Keywords has-patch added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 4.3
  • Priority changed from low to normal
  • Summary changed from Gaelic opening single quote instead of apostrophe to 'Cockney' filter needs to be translated

#9 follow-up: @akerbeltzalba
4 years ago

Looking at the diff, it seems that a list was supplied for Cockney words. Do I need to supply a similar list for Gaelic?

#10 in reply to: ↑ 9 @miqrogroove
4 years ago

Replying to akerbeltzalba:

Looking at the diff, it seems that a list was supplied for Cockney words. Do I need to supply a similar list for Gaelic?

Currently, the only elegant way to do this is with a plugin. After the core changes are released in a new version, it will be possible for the Gaelic translation authors to substitute the translated words as part of the Gaelic package, and then a plugin would not be needed.

@miqrogroove
4 years ago

More description for translators.

#11 @akerbeltzalba
4 years ago

Selling that as a plugin would be hard I think so I'd prefer to focus on the long-term solution. If it takes time to wait for a new version, so be it :)

Should I supply the list here?

#12 @miqrogroove
4 years ago

  • Owner set to miqrogroove
  • Status changed from new to accepted

#13 @wonderboymusic
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 32788:

Allow 'Cockney' filter to be translated.

Updates unit test.

Props miqrogroove.
Fixes #31953.

#14 follow-up: @akerbeltzalba
4 years ago

Thank you. I take it that means I should file a new bug with a list of affected words and refer to the Cockney feature?

#15 in reply to: ↑ 14 @yoavf
4 years ago

Replying to akerbeltzalba:

Thank you. I take it that means I should file a new bug with a list of affected words and refer to the Cockney feature?

Nope - the list of words will be added as a new entry to GlotPress where you will be able to "translate" it (or add to it).

#16 @akerbeltzalba
4 years ago

Ah I understand now. Yes, that works for me, thank you everybody!

Note: See TracTickets for help on using tickets.