WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#31963 closed defect (bug) (fixed)

Theme details modal: Dashicons for Left/Right/Close buttons are misaligned on iOS

Reported by: ocean90 Owned by: ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: Themes Keywords: good-first-bug has-patch
Focuses: ui Cc:

Description

That's because the user agent stylesheet has some custom padding for <button>'s, see attached screenshot.

Attachments (2)

31963.png (1.1 MB) - added by ocean90 4 years ago.
31963.diff (378 bytes) - added by awbauer 4 years ago.

Download all attachments as: .zip

Change History (9)

@ocean90
4 years ago

@awbauer
4 years ago

#1 @awbauer
4 years ago

Attached a patch, not sure if it's too general though.

#2 @awbauer
4 years ago

  • Keywords has-patch added; needs-patch removed

#3 @ryan
4 years ago

31963.diff looks better on my iPhone 6+ but about the same on iPhone 5. Nexus 5 remains correctly aligned.

#4 @awbauer
4 years ago

@ryan Any chance for a screenshot? This is what I've got on the iPhone 5 here: https://www.dropbox.com/s/99a8wv3yo31d81n/Screen%20Shot%202015-04-14%20at%2012.12.55%20PM.png

#5 @ryan
4 years ago

I suspected something was up with my environment. I had to restart the browser on my iPhone 5. The dismiss button is now correctly aligned on iPhone 5, iPhone 6+, and Nexus 5 when visiting the theme details modal via themes.php and via the customizer. iOS devices still require double taps to dismiss, but the alignment is correct.

Last edited 4 years ago by ryan (previous) (diff)

#6 @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 32128:

Reset padding for buttons in theme details modal.

props awbauer.
fixes #31963.

#7 @ocean90
4 years ago

  • Milestone changed from Future Release to 4.2
Note: See TracTickets for help on using tickets.