WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#31968 closed defect (bug) (fixed)

Press This: Upgrade bookmarklet notice appearing on directly accessed URL

Reported by: kraftbj Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Press This Keywords: has-patch
Focuses: Cc:

Description

In 4.2, one feature of Press This is the ability to directly access wp-admin/press-this.php and scanning a URL instead of only relying on the bookmarklet.

In [32106], bookmarklet version checking was moved to PHP to display if either the version is not indicated or under the current version (8).

Since the directly accessed URL will never have the version of the bookmarklet included, it is always displaying the notice.

Since the version number has been included in the bookmarklet since [7927], which had the bookmarklet pointing to /wp-admin/quick-post.php before it was branded as Press This, thus all released versions of WP has included the version number, it is probably safe to not display a notice if no version is present.

Attachments (1)

31968.diff (713 bytes) - added by kraftbj 4 years ago.
Changes empty check for isset so the notice does not display with no version is indicated.

Download all attachments as: .zip

Change History (3)

@kraftbj
4 years ago

Changes empty check for isset so the notice does not display with no version is indicated.

#1 @helen
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.2

Since we now include a direct link in Tools, moving into 4.2.

#2 @azaozz
4 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 32122:

Press This: do not show the bookmarklet upgrade notice when accessing directly press-this.php.
Props kraftbj. Fixes #31968.

Note: See TracTickets for help on using tickets.