Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#3198 closed defect (bug) (fixed)

Saving empty pages apears to work

Reported by: Nazgul Owned by: markjaquith
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.1
Component: Administration Keywords: has-patch
Focuses: Cc:


I'm splitting the reported bugs from #3053.

  1. Write Pages:(/wp-admin/post-new.php) Issue: when I hit "Save" button without providing any Values, the page created with the Blank values. We should validate this by a javascript which checks if the values is Blank the form should not be posted.

This is already partly fixed. The page isn't being saved, but you do get a confirmation that it is. Some validation beforehand would be nice.

Attachments (1)

3198.diff (1.2 KB) - added by majelbstoat 9 years ago.
Don't show success message when submitting blank values.

Download all attachments as: .zip

Change History (4)

9 years ago

Don't show success message when submitting blank values.

#1 @majelbstoat
9 years ago

  • Keywords has-patch added; needs-patch removed

Attached patch doesn't display the success message when saving or publishing blank data, rather than doing a client-side JS check.

This is also an issue for 2.0.4, and a possible candidate for 2.0.5, but the patch will have to be different as the blank data is still actually saved there - I can't find the exact commit where this behaviour changed in trunk.

#2 @markjaquith
9 years ago

  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

I'm committing the patch that kills the update message (trunk).

I think JS validation is overkill, as this is essentially an accidental click of the Publish button. No need to chastise them for their errant click.

Arguments to the contrary welcomed.

majelbstoat: don't worry about patching for 2.0.5 if there is a big behavior difference

#3 @markjaquith
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4338]) Publishing of blank pages or posts now kicks you back to the appropriate Write screen without an errant message. Props majelbstoat. fixes #3198

Note: See TracTickets for help on using tickets.