WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#31984 closed defect (bug) (fixed)

Shiny Updates - some glitches

Reported by: pavelevap Owned by: jorbin
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:

Description

Please see attached screenshot.

1) After update there is missing bottom line.

2) After update there is 5px more space which is added before success box.

Attachments (4)

Shiny_updates_bug.png (8.6 KB) - added by pavelevap 4 years ago.
31984.diff (478 bytes) - added by pareshradadiya 4 years ago.
31984.1.diff (1.1 KB) - added by pareshradadiya 4 years ago.
Missing line fix
31984.2.patch (630 bytes) - added by afercia 4 years ago.

Download all attachments as: .zip

Change History (17)

#1 @SergeyBiryukov
4 years ago

  • Component changed from General to Upgrade/Install
  • Milestone changed from Awaiting Review to 4.2

#2 @pavelevap
4 years ago

And one more problem. I tested following plugin: https://wordpress.org/plugins/plugin-vulnerabilities/

It uses after_plugin_row action and Shiny Updates are not triggered after clicking. I am not sure if it is problem of plugin, but I did not see anything wrong?

This ticket was mentioned in Slack in #core by drew. View the logs.


4 years ago

#4 @jorbin
4 years ago

  • Owner set to jorbin
  • Status changed from new to assigned

@pareshradadiya
4 years ago

#5 @pareshradadiya
4 years ago

  • Keywords has-patch added

@pareshradadiya
4 years ago

Missing line fix

#6 @pareshradadiya
4 years ago

Patch is working well in chrome and firefox

https://cldup.com/zhLrZ28a_g.gif

Last edited 4 years ago by pareshradadiya (previous) (diff)

This ticket was mentioned in Slack in #core by drew. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by helen. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by helen. View the logs.


4 years ago

#10 @jorbin
4 years ago

  • Keywords commit added

31984.1.diff looks ready to go in

@afercia
4 years ago

#11 @afercia
4 years ago

Updated patch avoids to use :not, just gives higher specificity to the update box rule.

#12 @DrewAPicture
4 years ago

Tested IE8 before and after with 31984.2.patch, and it looks good.

#13 @helen
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32256:

Shiny Updates: Prevent the post-update success message from jumping.

props pareshradadiya, afercia.
fixes #31984.

Note: See TracTickets for help on using tickets.