WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31985, comment 39


Ignore:
Timestamp:
09/12/2015 09:24:20 PM (5 years ago)
Author:
jeremyfelt
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31985, comment 39

    initial v1  
    66
    77* I removed the `load_core_options` change and left the original as is. This would normally only fire during multisite's bootstrap and only do anything if a persistent object cache was not available. If we move it to `WP_Network()` without the object cache check, we end up setting cache values every time a `WP_Network` object is created. There's probably a way to prime persistent cache properly, but I'm not sure we need the existing load functionality every time a new object is created.
    8 * Similar to that, I took out the `set_site_name` method temporarily as it currently relies on `get_site_option()`, which only works with the current network. This makes it the perfect time to introduce a `get_network_option()` that also takes a `$network_id`. We're ready to go on that in #33814. Once that is available, some of this starts making more sense.
     8* Similar to that, I took out the `set_site_name` method temporarily as it currently relies on `get_site_option()`, which only works with the current network. This makes it the perfect time to introduce a `get_network_option()` that also takes a `$network_id`. We're ready to go on that in #28290. Once that is available, some of this starts making more sense.