Theme Customizer: Widget search field hidden in Safari

[dsmart]

The customizer's text field to search for widgets does not show in safari.

This video should suffice in explaining.
​https://cloudup.com/cRJXA-T2Z6f

Testing environment:
WordPress Trunk 4.2-RC1-32138 running default Twenty Fifteen theme (also tested with 2014 theme) and no active plugins.
Safari Version 8.0.4 (10600.4.10.7)

[dsmart]

patch file

[westonruter]

@dsmart Could you determine when this regression was introduced?

[dsmart]

@westonruter blames back to [31227] when the search field was set to fixed #30751

[ocean90]

Hello dsmart, welcome to trac.
There is no need to patch RTL files - they are automatically created in the build process.

overflow: visible doesn't work because the view needs to be scrollable. 31987.2.diff​ is another approach. Side effect: The scroll bar will overlay the search container.

[dsmart]

@Ocean90 I see what you mean now. (ignore the third diff - duplicate)

[dsmart]

Here's a solution that involves wrapping the widget list in its own element: 31987.4.diff

This way scrolling is contained so it doesn't overflow over the search input area.

[helen]

31987.4.diff​ overlays the header on narrow screen / controls-only view, which blocks the close button. The autofocus-keyboard-flyup is also infuriating, we should probably address that while we're in here.

[dsmart]

31987.5.diff - No longer hides close button on narrow screens.

31987.6.diff - Does the same, plus it removes the initial .focus() event from the text input, which will succeed in not activating the keyboard on mobile.

[dsmart]

mobile love

[dsmart]

mobile love + no focus()

[helen]

In 32243:

Customizer: Better experience for widget filtering in desktop and iOS Safari.

Previously, the search field did not appear at all in desktop Safari, and the auto-focus keyboard fly-up in iOS rendered widget adding frustrating at best.

props dsmart, ocean90.
fixes #31987.

[helen]

A note that this does now make the search field fixed/always visible in controls-only mode (e.g. portrait phone), which is a little bit of a change but something we can address post-4.2 if it really does present as an issue. My personal take is that it is not really an issue, or at least not more than any other number of issues we have in the touch+narrow screen context.