TinyMCE: pasting an embeddable URL in Firefox doesn't show preview

[azaozz]

Caused by our regex test whether the selected parahraph has any text content.

When there is no text content (most common case), typeof( node.textContent || node.innerText ) is "undefined" in Firefox but "string" in Chrome. The regex test fails for undefined and passes for string.

[azaozz]

In 31988.patch: if the node doesn't have textContent or innerText (for old IE), pass empty string to the regex.

[DrewAPicture]

31988.patch​ fixes it for me. Nice find, this has been a longstanding problem for me.

[iseulde]

It fails because Firefox does not support node.innerText. That runs because node.textContent may evaluate false if it's an empty string and so null is returned. Patch fixes the problem, but maybe better to use the TinyMCE API for these things?

[DrewAPicture]

Tested 31988.2.patch​, and it also works for me. Moving for commit consideration.

[azaozz]

Yeah, we can use either patch, they are equivalent. I'd still do

/^[\s\uFEFF\u00A0]*$/.test( $( node ).text() || '' )

just in case as it is passed directly to a regex method that expects string.

[azaozz]

In 32229:

TinyMCE: fix creating a preview when pasting an embeddable URL in Firefox.
Part prop iseulde. Fixes #31988.