Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#31999 closed defect (bug) (fixed)

Duplicate translators comments

Reported by: pavelevap Owned by: ocean90
Milestone: 4.2 Priority: lowest
Severity: trivial Version: 2.8
Component: I18N Keywords: has-patch
Focuses: Cc:


When same string is used with different translators comments, it looks strange in GlotPress. See attached screenshot.

There are several possibilities:

  • Only one comment for first occurence (see attached patch).
  • Duplicate same comment for all places.

Attachments (4)

Duplicate_translators_comments.png (13.2 KB) - added by pavelevap 5 years ago.
duplicate_comments.patch (1.4 KB) - added by pavelevap 5 years ago.
31999.patch (2.8 KB) - added by pavelevap 5 years ago.
31999.2.patch (2.8 KB) - added by pavelevap 5 years ago.

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.2

Let's use the same comment for both strings.

5 years ago

5 years ago

#2 @pavelevap
5 years ago

There are 4 places...

Are there any standards for translators comments?

#3 @netweb
5 years ago

  • Keywords has-patch added

#4 @ocean90
5 years ago

  • Priority changed from normal to lowest
  • Severity changed from normal to trivial
  • Version changed from trunk to 2.8

Looks like introduced in [11506].

Patch looks good.

#5 @DrewAPicture
5 years ago

  • Owner set to ocean90
  • Status changed from new to reviewing

#6 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 32210:

Merge two different translator comments for the same string.

props pavelevap.
fixes #31999.

Note: See TracTickets for help on using tickets.