WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#31999 closed defect (bug) (fixed)

Duplicate translators comments

Reported by: pavelevap Owned by: ocean90
Priority: lowest Milestone: 4.2
Component: I18N Version: 2.8
Severity: trivial Keywords: has-patch
Cc: Focuses:

Description

When same string is used with different translators comments, it looks strange in GlotPress. See attached screenshot.

There are several possibilities:

  • Only one comment for first occurence (see attached patch).
  • Duplicate same comment for all places.

Attachments (4)

Duplicate_translators_comments.png​ (13.2 KB ) - added by pavelevap 11 years ago.
duplicate_comments.patch​ (1.4 KB ) - added by pavelevap 11 years ago.
31999.patch​ (2.8 KB ) - added by pavelevap 11 years ago.
31999.2.patch​ (2.8 KB ) - added by pavelevap 11 years ago.

Download all attachments as: .zip

Change History (10)

@pavelevap
11 years ago

@pavelevap
11 years ago

#1 @SergeyBiryukov
11 years ago

  • Milestone Awaiting Review → 4.2

Let's use the same comment for both strings.

@pavelevap
11 years ago

@pavelevap
11 years ago

#2 @pavelevap
11 years ago

There are 4 places...

Are there any standards for translators comments?

#3 @netweb
11 years ago

  • Keywords has-patch added

#4 @ocean90
11 years ago

  • Priority normal → lowest
  • Severity normal → trivial
  • Version trunk → 2.8

Looks like introduced in [11506].

Patch looks good.

#5 @DrewAPicture
11 years ago

  • Owner set to ocean90
  • Status new → reviewing

#6 @SergeyBiryukov
11 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 32210:

Merge two different translator comments for the same string.

props pavelevap.
fixes #31999.

Note: See TracTickets for help on using tickets.