Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#32000 closed enhancement (fixed)

Some translators comments

Reported by: pavelevap Owned by: SergeyBiryukov
Priority: lowest Milestone: 4.2
Component: I18N Version: 4.2
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

I could not find where are some strings displayed and that is why I vote for adding translators comments. These strings can be translated a little bit different when you know where will be displayed (Javascript for screen readers). See attached patch.

Attachments (2)

javascript_accessible.patch (1.2 KB ) - added by pavelevap 11 years ago.
32000.patch (1.2 KB ) - added by pavelevap 11 years ago.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
11 years ago

  • Milestone Awaiting Review4.2

#2 follow-up: @ocean90
11 years ago

  • Priority normallowest
  • Type defect (bug)enhancement

Some thoughts to javascript_accessible.patch:

  • "Javascript" should be "JavaScript"
  • The beforeunload string is not used for accessibility.
  • What's the difference between translating a regular sting and a string for accessibility?

#3 in reply to: ↑ 2 @pavelevap
11 years ago

Replying to ocean90:

  • "Javascript" should be "JavaScript"

Sorry, fixed.

  • The beforeunload string is not used for accessibility.

Sorry, lines were moved, fixed.

  • What's the difference between translating a regular sting and a string for accessibility?

Sometimes strings can be translated in another context when we know that people will not see them, but only hear them. Translators should know about that, but it is not a big deal.

@pavelevap
11 years ago

#4 @DrewAPicture
11 years ago

  • Keywords has-patch added
  • Owner set to ocean90
  • Status newreviewing

#5 @DrewAPicture
11 years ago

  • Owner changed from ocean90 to SergeyBiryukov

#6 @SergeyBiryukov
11 years ago

  • Resolutionfixed
  • Status reviewingclosed

In 32211:

Make translator comments for the strings added in [31982] more accurate. Add some new comments.

props pavelevap.
fixes #32000.

#7 @SergeyBiryukov
10 years ago

In 40033:

I18N: Use a consistent translator comment ("accessibility text") for strings used in aria-label attributes.

See #32000.

Note: See TracTickets for help on using tickets.