WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#32003 closed defect (bug) (fixed)

When adding a caption to an image, an empty paragraph remains after the caption wrapper

Reported by: azaozz Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: has-patch commit
Focuses: Cc:

Description

Caused by trying to remove the previous image parentNode (usually <p>) too soon.

Attachments (1)

32003.patch (1.3 KB) - added by azaozz 4 years ago.

Download all attachments as: .zip

Change History (7)

@azaozz
4 years ago

#1 @azaozz
4 years ago

In 32003.patch: attempt to remove the previous image parent paragraph a bit later.

This ticket was mentioned in Slack in #core-editor by azaozz. View the logs.


4 years ago

#3 @iseulde
4 years ago

  • Version trunk deleted

This ticket was mentioned in Slack in #core-editor by ocean90. View the logs.


4 years ago

#5 @ocean90
4 years ago

  • Keywords has-patch commit added

Test case: Insert an image without a caption, then add a caption (from the Edit Image modal)

Tested in Firefox and Chrome, 32003.patch fixes the issue.
While testing I noticed a shifted caption in Firefox, which is handed by #32007.

#6 @azaozz
4 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 32141:

TinyMCE: remove the empty paragraph that sometimes is left over after adding an image caption.
Fixes #32003.

Note: See TracTickets for help on using tickets.