Make WordPress Core

Opened 12 years ago

Closed 11 years ago

#32007 closed defect (bug) (fixed)

Twenty Fifteen: Image captions are shifted down in TinyMCE

Reported by: azaozz Owned by: azaozz
Priority: normal Milestone: 4.2
Component: Bundled Theme Version:
Severity: normal Keywords:
Cc: Focuses:

Description

Happens only in Firefox as the caption <dt> is padded with <br data-mce-bogus="1"> (like any other empty block element in the editor).

Caused by a img { display: block } in the theme's editor-style.css.

Attachments (1)

caption-in-firefox.png​ (133.4 KB ) - added by azaozz 12 years ago.

Download all attachments as: .zip

Change History (9)

#1 @azaozz
12 years ago

Not sure why images that are wrapped in links have to be display:block inside the editor. Removing that doesn't seem to break anything.

Last edited 12 years ago by azaozz (previous) (diff)

#2 @SergeyBiryukov
12 years ago

  • Summary Image captions are shifter down when Twenty Fifteen is used → Twenty Fifteen: Image captions are shifted down in TinyMCE

This ticket was mentioned in ​Slack in #core-editor by azaozz. ​View the logs.


12 years ago

#6 @DrewAPicture
11 years ago

  • Owner set to azaozz
  • Status new → reviewing

This ticket was mentioned in ​Slack in #core by drew. ​View the logs.


11 years ago

#8 @azaozz
11 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 32231:

Twenty Fifteen: remove a img { display: block; } from editor-style.css. Matches previous changes to style.css and fixes extra space when displaying captions in Firefox.
Fixes #32007.

Note: See TracTickets for help on using tickets.