WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Last modified 6 days ago

#32017 new defect (bug)

Fix class name typo from 'hndle' to 'handle'

Reported by: michalzuber's profile michalzuber Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch needs-testing
Focuses: Cc:

Description

The typo was introduced in [8682] changeset.

Attachments (5)

32017.diff​ (4.5 KB) - added by michalzuber 10 years ago.
Replaced strings 'hndle' to 'handle'
32017.2.diff​ (6.6 KB) - added by salcode 10 years ago.
32017.3.diff​ (11.9 KB) - added by palmiak 7 years ago.
Refreshed path
17851.4.diff​ (11.8 KB) - added by palmiak 7 years ago.
refreshed file with backward compatibility
32017.4.patch​ (5.8 KB) - added by bookdude13 5 years ago.
Refreshed patch (last one corrupt?)

Download all attachments as: .zip

Change History (13)

@michalzuber
10 years ago

Replaced strings 'hndle' to 'handle'

#1 @ocean90
10 years ago

We can't change it without leaving the old class for backwards compatibilty.

#2 @swissspidy
10 years ago

  • Component changed from General to Administration
  • Keywords has-patch needs-refresh added

What ocean90 says :)

Last edited 10 years ago by swissspidy (previous) (diff)

@salcode
10 years ago

#3 @salcode
10 years ago

  • Keywords needs-refresh removed

@johnlauber and I took a pass at updating this patch to include backwards compatibility at #WCUS

#4 @antpb
7 years ago

  • Keywords needs-refresh added

@palmiak
7 years ago

Refreshed path

#5 @swissspidy
7 years ago

@palmiak You'd need to refresh 32017.2.diff​, not 32017.diff​ because of the comment before:

We can't change it without leaving the old class for backwards compatibility.

#6 @palmiak
7 years ago

Ok - so not find & replace but find & add :) I'll try to do it during the weekend or on monday

@palmiak
7 years ago

refreshed file with backward compatibility

@bookdude13
5 years ago

Refreshed patch (last one corrupt?)

#7 @bookdude13
5 years ago

  • Keywords needs-testing added; needs-refresh removed

Hey all, sorry for this being so delayed :/

The patch was corrupted for me, so made my own off of trunk (16 Jan 2020). A quick glance on the dashboard page source makes this look like it works, but needs actual checking.

This ticket was mentioned in ​PR #9180 on ​WordPress/wordpress-develop by ​@sainathpoojary.
6 days ago #8

Trac ticket: #32017

Note: See TracTickets for help on using tickets.