WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Last modified 7 days ago

#32017 new defect (bug)

Fix class name typo from 'hndle' to 'handle'

Reported by: michalzuber's profile michalzuber Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch has-screenshots
Focuses: Cc:

Description

The typo was introduced in [8682] changeset.

Attachments (5)

32017.diff​ (4.5 KB) - added by michalzuber 11 years ago.
Replaced strings 'hndle' to 'handle'
32017.2.diff​ (6.6 KB) - added by salcode 10 years ago.
32017.3.diff​ (11.9 KB) - added by palmiak 8 years ago.
Refreshed path
17851.4.diff​ (11.8 KB) - added by palmiak 8 years ago.
refreshed file with backward compatibility
32017.4.patch​ (5.8 KB) - added by bookdude13 6 years ago.
Refreshed patch (last one corrupt?)

Download all attachments as: .zip

Change History (14)

@michalzuber
11 years ago

Replaced strings 'hndle' to 'handle'

#1 @ocean90
11 years ago

We can't change it without leaving the old class for backwards compatibilty.

#2 @swissspidy
10 years ago

  • Component changed from General to Administration
  • Keywords has-patch needs-refresh added

What ocean90 says :)

Last edited 10 years ago by swissspidy (previous) (diff)

@salcode
10 years ago

#3 @salcode
10 years ago

  • Keywords needs-refresh removed

@johnlauber and I took a pass at updating this patch to include backwards compatibility at #WCUS

#4 @antpb
8 years ago

  • Keywords needs-refresh added

@palmiak
8 years ago

Refreshed path

#5 @swissspidy
8 years ago

@palmiak You'd need to refresh 32017.2.diff​, not 32017.diff​ because of the comment before:

We can't change it without leaving the old class for backwards compatibility.

#6 @palmiak
8 years ago

Ok - so not find & replace but find & add :) I'll try to do it during the weekend or on monday

@palmiak
8 years ago

refreshed file with backward compatibility

@bookdude13
6 years ago

Refreshed patch (last one corrupt?)

#7 @bookdude13
6 years ago

  • Keywords needs-testing added; needs-refresh removed

Hey all, sorry for this being so delayed :/

The patch was corrupted for me, so made my own off of trunk (16 Jan 2020). A quick glance on the dashboard page source makes this look like it works, but needs actual checking.

This ticket was mentioned in ​PR #9180 on ​WordPress/wordpress-develop by ​@sainathpoojary.
7 months ago #8

Trac ticket: #32017

#9 @ozgursar
7 days ago

  • Keywords has-screenshots added; needs-testing removed

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/9180

Environment

  • WordPress: 7.0-alpha-61215-src
  • PHP: 8.2.29
  • Server: nginx/1.29.4
  • Database: mysqli (Server: 8.4.7 / Client: mysqlnd 8.2.29)
  • Browser: Chrome 143.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-One 2.7
  • MU Plugins: None activated
  • Plugins:
    • Classic Editor 1.6.7
    • Test Reports 1.2.1

Steps to Reproduce

  1. Install Classic Editor plugin
  2. Edit any post
  3. Inspect any postbox header using Chrome Dev Tools to see the classlist of H2 element

Actual Results

  1. ✅ Issue resolved with patch.
  2. .handle class is added to the div.postbox-header > h2 tag and .hndl class is kept for backwards compatibility.
  3. Metabox toggle works as expected.

Additional Notes

  • As the test steps weren't clearly provided, I tested only by toggling metaboxes by clicking their headers.

Supplemental Artifacts

Before After
https://files.catbox.moe/8nqa3e.png https://files.catbox.moe/od9fdr.png
Last edited 7 days ago by ozgursar (previous) (diff)
Note: See TracTickets for help on using tickets.