Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#32021 closed defect (bug) (fixed)

Make three untranslatable strings, translatable

Reported by: jrf's profile jrf Owned by: ocean90's profile ocean90
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: ui Cc:

Description

While working on #31950, I came across three untranslatable strings.

Sending a separate patch in for those now at johnbillion's suggestion.

I *have* included the string in wp_db.php as well in this patch, in contrast to his suggestion, as wp_load_translations_early() is called within the same function and __() is used for other strings within the function too, so language functions should be available.

Attachments (2)

0001-Fix-three-untranslatable-strings.patch (2.1 KB) - added by jrf 11 years ago.
0001-Fix-four-untranslatable-strings.patch (2.4 KB) - added by jrf 11 years ago.

Download all attachments as: .zip

Change History (15)

#1 @jrf
11 years ago

  • Keywords has-patch added

#3 @jrf
11 years ago

@SergeyBiryukov you're completely right - uploaded a new patch which includes that string too.
Sorry, the other patch from which I subtracted this one focused only on echo statements, so I missed this one ;-)

#4 @SergeyBiryukov
11 years ago

  • Keywords 4.3-early added
  • Milestone changed from Awaiting Review to Future Release

No apologies necessary, thanks for the patch :)

#5 @obenland
11 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

#6 @obenland
11 years ago

  • Keywords 4.3-early removed
  • Milestone changed from Future Release to 4.3

This ticket was mentioned in Slack in #core by helen. View the logs.


11 years ago

#8 @ocean90
11 years ago

  • Owner changed from SergeyBiryukov to ocean90

#9 @ocean90
11 years ago

In 33006:

wpdb: Make "WordPress database error:" translatable.

props jrf.
see #32021.

#10 @ocean90
11 years ago

In 33007:

Make WP_Locale::rtl_src_admin_notice() translatable.

props jrf.
see #32021.

#11 follow-up: @ocean90
11 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33008:

Remove unnecessary feedback message from WP_Importer::is_user_over_quota().

fixes #32021.

#12 in reply to: ↑ 11 @ocean90
11 years ago

Replying to ocean90:
None of the importer plugins are using this method currently. I'm also not quite sure in which context WP_Importer can be run so adding i18n as a dependency could break things.

#13 @markoheijnen
11 years ago

Shouldn't we skip translating the error messages in error_log? If people want to collect error logs then making the message variable makes that almost impossible.

Note: See TracTickets for help on using tickets.