WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#32047 closed enhancement (fixed)

Merge two strings from theme details dialog

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 4.3 Priority: low
Severity: trivial Version: 4.2
Component: Themes Keywords: good-first-bug has-patch
Focuses: accessibility Cc:

Description

We have two strings for the Close button in theme details dialog:

Can we use the latter for both?

Attachments (1)

32047.patch (834 bytes) - added by McGuive7 5 years ago.
Switch themes screenreader text to match customizer: "Close details dialog"

Download all attachments as: .zip

Change History (5)

#1 @SergeyBiryukov
5 years ago

  • Priority changed from normal to low
  • Severity changed from normal to trivial

#2 @obenland
5 years ago

  • Focuses accessibility added
  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 4.3

I think that would make sense.

Adding a11y focus since it's screen reader text.

@McGuive7
5 years ago

Switch themes screenreader text to match customizer: "Close details dialog"

#3 @McGuive7
5 years ago

  • Keywords has-patch added; needs-patch removed

And. . . added. This patch simply changes the screenreader text in themes.php (themes screen) to match that in theme.php (customizer screen). Both now read: "Close details dialog"

#4 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 32332:

Merge two strings from theme details dialog.

props McGuive7.
fixes #32047.

Note: See TracTickets for help on using tickets.