Filesystem Credentials Request Modal: Inline JavaScript focuses every first input of a form

[ocean90]

Originally reported by sergej.mueller:

When wp_print_request_filesystem_credentials_modal() is called and credentials are required request_filesystem_credentials() is printed. That includes some inline JavaScript:

<script type="text/javascript">
<!--
jQuery(function($){
	jQuery("#ssh").click(function () {
		jQuery("#ssh_keys").show();
	});
	jQuery("#ftp, #ftps").click(function () {
		jQuery("#ssh_keys").hide();
	});
	jQuery('form input[value=""]:first').focus();
});
-->
</script>

The last line will focus every first input of a form. On wp-admin/plugins.php this will be the search input.

[valendesigns]

We could target the form pretty easily and fix this. Uploaded a quick patch.

[valendesigns]

CSS id instead of class.

[DrewAPicture]

Tested 32055.1.diff​ on wp-admin/plugins.php and wp-admin/network/plugins.php and the search field is no longer focused. On the FS credentials modal, the first field is still focused on launch as expected.

@ocean90: are there any other screens we should be testing?

[ocean90]

In 32266:

Don't focus input fields outside of the request filesystem credentials form.

props valendesigns.
fixes #32055.