get_image_send_to_editor() improperly documented

[tychay]

​https://developer.wordpress.org/reference/functions/get_image_send_to_editor/#source-code

https://core.trac.wordpress.org/browser/tags/4.1/src/wp-admin/includes/media.php#101

$rel does not support string input as written. Either change the documentation on line 112 to be bool only, or change line 120 to read

<?php
        if ( !$rel || !is_string($rel) ) {
                $rel = $rel ? ' rel="attachment wp-att-' . esc_attr($id).'"' : '';
        } else {
                $rel = ' rel="' . esc_attr($rel).'"';
        }

or…

<?php
        if ( !$rel || !is_string($rel) ) {
                $rel = $rel ? ' rel="attachment wp-att-' . esc_attr($id).'"' : '';
        }

depending on what the doc means (it's not clear).

[DrewAPicture]

Hi @tychay, would you like to try your hand at creating a patch?

[wonderboymusic]

In 34259:

Media: In get_image_send_to_editor(), allow a custom value for $rel.

Props tychay.
Fixes #32074.

[helen]

In 35760:

Media: Avoid rel="rel=" situations.

props lucymtc, swissspidy.
fixes #34826. see #32074.