WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #32078, comment 20


Ignore:
Timestamp:
05/19/2015 07:45:31 PM (11 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #32078, comment 20

    initial v1  
    11Looking at 32078.3.patch:
    2 - Thinking it's good to have the nested <p> removal regex when inserting the markers. This is currently fixed in the "wordpress" [plugin https://core.trac.wordpress.org/browser/branches/4.2/src/wp-includes/js/tinymce/plugins/wordpress/plugin.js#L321] but why should we be inserting invalid HTML in the first place.
     2- Thinking it's good to have the nested <p> removal regex when inserting the markers. This is currently fixed in the 'wordpress' MCE plugin: https://core.trac.wordpress.org/browser/branches/4.2/src/wp-includes/js/tinymce/plugins/wordpress/plugin.js#L321 but why should we be inserting invalid HTML in the first place.
    33- We should keep emptying the view nodes at the beginning of the TinyMCE DOM cleanup. This makes it faster and fixes some edge cases where different "filters" on the content are triggered by the view nodes or serialized HTML, sometimes resulting in errors.