WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#32111 closed defect (bug) (duplicate)

Problem in spanish version with buttons for publish

Reported by: ramonjosegn Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.2
Component: Posts, Post Types Keywords: good-first-bug needs-testing has-patch
Focuses: ui, administration Cc:
PR Number:

Description

Hello dears

There is a problem with the buttons position in the spanish version of Wordpress 4.2

I upload a screencapture

Thanks for support

http://s21.postimg.org/iwohsibfr/error_botones_spanish.jpg

Attachments (2)

32111.patch (151.5 KB) - added by Rynald0s 4 years ago.
Proposed patch
32111.2.patch (669 bytes) - added by Rynald0s 4 years ago.
Proposed patch for #32111 and #20842

Download all attachments as: .zip

Change History (20)

#1 @SergeyBiryukov
5 years ago

  • Component changed from General to Posts, Post Types
  • Focuses ui administration added

#2 @leemon
4 years ago

The same is happening in the Catalan version

http://s29.postimg.org/vvsbt6n6f/cat.png

#3 @ocean90
4 years ago

Related: #20842

#4 @wonderboymusic
4 years ago

  • Keywords good-first-bug needs-patch added
  • Milestone changed from Awaiting Review to 4.4

#5 follow-up: @leemon
4 years ago

I managed to fix this issue using the following code. But, I'm sure this can't be that easy and I'm leaving edge cases out.

#save-action {
    float: left;
    width: 50%;
}

#preview-action {
    float: right;
    width: 50%;
}

#6 in reply to: ↑ 5 @juanfra
4 years ago

The problem with that code is that it'll take the spinner to a new line. Plus, for some other languages it will make both buttons overlap.

@Rynald0s
4 years ago

Proposed patch

#7 @Rynald0s
4 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#8 follow-ups: @SergeyBiryukov
4 years ago

  • Keywords needs-patch added; has-patch removed

@Rynald0s, thanks for the patch! However, minified files should not be patched, our build tools take care of that.

Could you provide a patch for the non-minified file? Use the SCRIPT_DEBUG constant for that.

#9 in reply to: ↑ 8 @Rynald0s
4 years ago

Replying to SergeyBiryukov:

@Rynald0s, thanks for the patch! However, minified files should not be patched, our build tools take care of that.

Could you provide a patch for the non-minified file? Use the SCRIPT_DEBUG constant for that.

Absolutely. Thanks so much, Sergey.

@Rynald0s
4 years ago

Proposed patch for #32111 and #20842

#10 in reply to: ↑ 8 @Rynald0s
4 years ago

  • Keywords has-patch added; needs-patch removed

Replying to SergeyBiryukov:

@Rynald0s, thanks for the patch! However, minified files should not be patched, our build tools take care of that.

Could you provide a patch for the non-minified file? Use the SCRIPT_DEBUG constant for that.

done

Last edited 4 years ago by Rynald0s (previous) (diff)

#11 follow-up: @juanfra
4 years ago

Nice! unfortunately that patch will leave the preview button unaligned with the "Publish" button.

https://cldup.com/Gk63ulHKJz-3000x3000.png

At the same time, for other languages like the ones mentioned in #20842 (I guess russian and arabic), this patch won't take effect, because they have larger strings.

I think the only way to get this solved is thinking about a new distribution for the buttons. With things as they are right now, we'll always depend on the length of the string, and that varies from language to language.

#12 in reply to: ↑ 11 ; follow-up: @Rynald0s
4 years ago

Replying to juanfra:

Nice! unfortunately that patch will leave the preview button unaligned with the "Publish" button.

https://cldup.com/Gk63ulHKJz-3000x3000.png

At the same time, for other languages like the ones mentioned in #20842 (I guess russian and arabic), this patch won't take effect, because they have larger strings.

I think the only way to get this solved is thinking about a new distribution for the buttons. With things as they are right now, we'll always depend on the length of the string, and that varies from language to language.

Was looking at the translated strings for Russian and Arabic languages (#20842). The string in Russian language you see in the image doesn't correspond with the string in the translation file as it is today. Then again, this was 3 years ago so it appears that this issue was resolved by simply taking the languages that has long strings ('Save Draft' button), and making them smaller.

That said, disregard the proposed patch and instead, we could just change the string in Spanish language files from "Guardar borrador", to only "Guardar", and in Catalan language files from "Desa l'esborrany" to only "Desa." The same has been done for Russian language. This will be the new proposed 'patch'.

I have already made the translation suggestions for Spanish & Catalan languages. As per #20842, both Russian and Arabic displays correctly so this could be marked as complete/solved.

Thanks

Last edited 4 years ago by Rynald0s (previous) (diff)

#13 follow-up: @juanfra
4 years ago

Awesome. Have you sent a message with this new translation suggestion?

Last edited 4 years ago by juanfra (previous) (diff)

#14 in reply to: ↑ 13 @Rynald0s
4 years ago

Replying to juanfra:

Awesome. Have you sent a message with this new translation suggestion?

I have suggested the new translation strings.

#15 follow-up: @juanfra
4 years ago

Yep, I saw the new string suggestion in polyglots. But, have you accompanied that suggestion with a message to the reviewer with a reference to this ticket?

I've contacted the Spanish translation team in order to aware them of this new suggestion.

Last edited 4 years ago by juanfra (previous) (diff)

#16 in reply to: ↑ 15 @Rynald0s
4 years ago

Replying to juanfra:

Yep, I saw the new string suggestion in polyglots. But, have you accompanied that suggestion with a message to the reviewer with a reference to this ticket?

I've contacted the Spanish translation team in order to aware them of this new suggestion.

Ah, no I have not done that. Thanks for letting them know.

#17 in reply to: ↑ 12 @SergeyBiryukov
4 years ago

Replying to Rynald0s:

Was looking at the translated strings for Russian and Arabic languages (#20842). The string in Russian language you see in the image doesn't correspond with the string in the translation file as it is today. Then again, this was 3 years ago so it appears that this issue was resolved by simply taking the languages that has long strings ('Save Draft' button), and making them smaller.

Actually, the string is still there:

And the screenshot from comment:4:ticket:20842 is still relevant. The string in question is not "Save Draft", but "Save as Pending", which is displayed for users with Contributor role.

#18 @SergeyBiryukov
4 years ago

  • Milestone 4.4 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Let's continue working on this in #20842, since it's essentially the same issue.

Note: See TracTickets for help on using tickets.