Opened 9 years ago
Closed 9 years ago
#32128 closed defect (bug) (fixed)
Emoji error loop
Reported by: | obenland | Owned by: | azaozz |
---|---|---|---|
Milestone: | 4.2.2 | Priority: | normal |
Severity: | normal | Version: | 4.2 |
Component: | Formatting | Keywords: | fixed-major has-patch |
Focuses: | javascript | Cc: |
Description
If the emoji scripts has to replace emojis with images but the images can't be found, twemoji replaces those images with the image's alt attribute. wp-emoji has a listener in place to then again run the emoji script over theses nodes, resulting in an infinite replacement loop. At least that's what I think happens.
Attachments (2)
Change History (10)
#4
@
9 years ago
The documentation says object
can also be a string, so doing object.className
without any other checks is not good. It's probably better to even prevent that function from executing and handle it in the mutation observer callback.
#5
@
9 years ago
The second patch is a bit more code, but should be faster, it runs earlier and less often.
#6
@
9 years ago
- Owner set to azaozz
- Resolution set to fixed
- Status changed from new to closed
In 32323:
Note: See
TracTickets for help on using
tickets.
Probably not the most elegant solution.