wp_get_attachment_url() append /sites/$blog_id/ twice in url

[pareshradadiya]

WordPress doesn't allow you to attach an already-attached image to another post. At the minute, I must re-upload the same image if I want to do this. So when I use wp_get_attachment_url() to get attachments url, It append /sites/$blog_id/ twice for all re-uploaded attachments.

[pareshradadiya]

Expected

​http://microtest.rttest.au/wp-content/uploads/sites/2/2015/04/comment-setting-150x150.png

Actual

​http://microtest.rttest.au/wp-content/uploads/sites/2/sites/2/2015/04/comment-setting-150x150.png

[wonderboymusic]

@pareshradadiya - can you provide your exact steps and code here... I cannot reproduce

[pareshradadiya]

The issue is only appears in the MU sites. This snippets is for creating a clone of an attachments

/**
 * Create a copy of the attachment.
 */
function test_clone_attachment() {

        /** Get an old attachment post by id **/
        $attachment1 = get_post( '4' );

        $args = array(
                'post_mime_type' => $attachment1->post_mime_type,
                'guid'           => $attachment1->guid,
                'post_title'     => $attachment1->post_title,
                'post_content'   => $attachment1->post_content,
                'post_parent'    => 0,
        );

        $attachment2 = wp_insert_attachment( $args, wp_get_attachment_url( $attachment1->ID ), '0' );

        echo( wp_get_attachment_url( $attachment2 ) );

}

add_action( 'init', 'test_clone_attachment' );
 

[jeremyfelt]

wp_insert_attachment() expects a file location on the server rather than a URL. Using get_attached_file() instead to grab the file location as it's stored in post meta will create the proper attachment URL.

$attachment2 = wp_insert_attachment( $args, get_attached_file( $attachment1->ID ), '0' );

I can't speak for how solid things are after that when juggling a file attached to multiple posts, but it appears the code above will work with this change.

[jorbin]

While the decision to close is being made (this is not a comment on that), moving to future release so that the awaiting review report can be easier to follow.

[jeremyfelt]

I think we can close this out. @pareshradadiya, please feel free to comment or reopen if needed. Reworking your code example should do the trick.