Make WordPress Core

Opened 11 years ago

Closed 9 years ago

#32151 closed feature request (maybelater)

Add TuneIn to oEmbed whitelist

Reported by: ccoffman's profile ccoffman Owned by: johnbillion's profile johnbillion
Milestone: Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch reporter-feedback
Focuses: Cc:

Description

TuneIn has recently added functionality for embedding live streaming stations on third party sites.

Details below:

URL scheme: http://tunein.com/*
URL scheme: http://tun.in/*
API endpoint: http://tunein.com/oembed/
Example: http://tunein.com/oembed/?url=http%3A%2F%2Ftunein.com%2Fradio%2FKQED-FM-885-s34804%2F

More about TuneIn:
TuneIn enables people to discover, follow and listen to what's most important to them — from sports, to news, to music, to talk. TuneIn provides listeners access to over 100,000 real radio stations and more than four million podcasts streaming from every continent. We have over 50 million monthly active listeners in 230 countries & territories. See http://en.wikipedia.org/wiki/TuneIn, http://twitter.com/tunein, and http://Facebook.com/tunein

Attachments (2)

32151-1.patch (1.0 KB) - added by dmchale 11 years ago.
32151-2.patch (906 bytes) - added by dmchale 11 years ago.

Download all attachments as: .zip

Change History (18)

#1 @johnbillion
11 years ago

  • Component changed from General to Embeds
  • Milestone changed from Awaiting Review to 4.3
  • Type changed from defect (bug) to feature request

#2 @dmchale
11 years ago

  • Keywords has-patch added

In addition to the OP's provided stats on the tunein service, they have verified facebook and twitter accounts with 464K Likes and 81.7K Followers respectively. Facebook claims 500,000+ users per month use their facebook app as well. Good amount of info on wiki here: wikipedia link. There's one hit in the wp.org repo for "Simple Follow Me Social Buttons Widget" which allows for linking an icon to the service. I couldn't readily find any docs on the site or via google for the oembed api, and the OP did say they "recently added" support for this.

Attaching a patch which updates /wp-includes/class-oembed.php to add support for the tunein service, of course pending final decision/review/approval.

@dmchale
11 years ago

@dmchale
11 years ago

#3 follow-up: @dmchale
11 years ago

Sorry, hadn't thoroughly tested the tun.in the short url provided by the OP.... doesn't actually work.

http://tunein.com/radio/The-Cat-s132203/ works fine

http://tun.in/radio/The-Cat-s132203/ throws a 404

Uploaded new patch which only supports tunein.com

#4 @obenland
11 years ago

  • Owner set to johnbillion
  • Status changed from new to assigned

#5 in reply to: ↑ 3 @netweb
11 years ago

  • Keywords reporter-feedback added

A couple of things per http://make.wordpress.org/core/handbook/design-decisions/#whitelisting-oembed-providers

Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.)

I cannot find any documentation here http://developers.tunein.com/

Does the service make an effort to build relationships with developers, such as through robust APIs?

So http://tun.in/* is provided by the OP but as @dmchale points out it 404's

Can you clarify these couple of things @ccoffman please.

#6 @ccoffman
11 years ago

@netweb The http://tun.in/* pattern is for TuneIn's url shortener, which works with short link codes generated on tunein.com. An functional example link is http://tun.in/seRun

We haven't yet published documentation on developers.tunein.com, however this is ticketed on our side and we hope to have it live soon.

We're passionate about giving our station and program owners & fans as many opportunities as possible to share and listen to live and on-demand content and the embedded player is a big part of this strategy.

#7 @wonderboymusic
11 years ago

  • Milestone changed from 4.3 to Future Release

I like this endpoint so far, but I think we should wait til short URLs work and their docs are updated. If those things happen in the next few days, then great!

#8 @johnbillion
10 years ago

  • Milestone changed from Future Release to 4.4

@ccoffman: How's about them oEmbed docs?

#9 @ccoffman
10 years ago

Hey-- we're working through our backlogs and this is next up. Will update this ticket as soon as it's live with the link (on developers.tunein.com). Thanks for your patience.

This ticket was mentioned in Slack in #core by sergey. View the logs.


10 years ago

#11 @SergeyBiryukov
10 years ago

@ccoffman: Any progress here?

#12 @ccoffman
10 years ago

@sergeybiryukov-- yes! This work is going on in our current web sprint. I'll post here as soon as it's live on our developers site.

#13 @johnbillion
10 years ago

@ccoffman Seeing as you're working on this currently, I've noticed that TuneIn fails one of the unit tests from #32360, which verify that our whitelisted providers adhere to the oEmbed spec.

The width property in TuneIn's oEmbed response includes a px unit instead of just a number. This is not valid according to the oEmbed spec section 2.3.4.4.

#14 @wonderboymusic
10 years ago

  • Milestone changed from 4.4 to Future Release

@johnbillion if you really feel passionately about this, toss it back in

#15 @swissspidy
10 years ago

@ccoffman: Any news here?

#16 @johnbillion
9 years ago

  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from assigned to closed

I'm closing this as maybelater to aid with issue management. This doesn't mean we won't add support for TuneIn, just that it's not mature enough at the moment. Discussion can continue while the ticket remains closed.

Note: See TracTickets for help on using tickets.