WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #32154, comment 12


Ignore:
Timestamp:
07/03/2015 04:47:18 AM (6 years ago)
Author:
johnjamesjacoby
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #32154, comment 12

    initial v1  
    33* Is `wp_should` a convention we want to continue to use? I picked `can` since it matches existing nomenclature, and arguably WordPress should upgrade all tables all the time, but currently cannot for x/y/z reasons.
    44* Why remove the `(bool)` type cast? I think it's better to be explicit after filters are applied, to ensure strict comparisons don't produce undesirable results, especially with something sensitive like this.
    5 
     5* Thanks for adding the filter documentation in. Sorry I missed that bit.