Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#32166 closed feature request (maybelater)

Add Play.fm to oEmbed whitelist

Reported by: pulse00's profile pulse00 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Embeds Keywords:
Focuses: Cc:

Description

https://www.play.fm is a platform for dj mixes which recently added oEmbed support to embed audio content into other websites.

URL scheme: https://www.play.fm/*
API endpoint: https://www.play.fm/<dj>/<mix>/oembed
Example: https://www.play.fm/pulse00/friedman-dub-mix/oembed

Change History (5)

#1 @pulse00
10 years ago

Can't edit the ticket description...

The correct info is:

URL scheme: https://www.play.fm/*/*
API endpoint: https://v2api.play.fm/oembed
Example: https://v2api.play.fm/oembed?url=https%3A%2F%2Fwww.play.fm%2Fpulse00%2Ffriedman-dub-mix

Last edited 10 years ago by pulse00 (previous) (diff)

#2 @johnbillion
10 years ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to 4.3

Hi pulse100, thanks for the suggestion.

Can you have a read through the following please and let us know the answers to the questions?

http://make.wordpress.org/core/handbook/design-decisions/#whitelisting-oembed-providers

#3 follow-up: @dmchale
10 years ago

pulse100, where did you find the documentation listing that v2api url for the oembed link? Just curious since that's not the path given in the oembed link tag when looking at the view-source on their site

johnbillion, according to the play.fm wikipedia entry "In 2015 a redesign of the web site was launched to improve usability and music related social networking". While it says it's been around since 2004 in general, it seems that the "new" version of the website may still be a little young for core integration. It also seems to not quite fit a few of the other items in the guidelines you linked to (documentation about the oembed api? non-verified twitter account, non-verified facebook page, no plugins for play.fm in the wp.org repo). Just over 5k twitter followers, just over 45k facebook followers, for whatever those numbers are worth.

Maybe reevaluate down the line and support it the future, but core support seems a little early based on those guidelines. My $0.02.

#4 in reply to: ↑ 3 @pulse00
10 years ago

  • Resolution set to maybelater
  • Status changed from new to closed

Replying to dmchale:

pulse100, where did you find the documentation listing that v2api url for the oembed link? Just curious since that's not the path given in the oembed link tag when looking at the view-source on their site

i know it because i'm one of the developers of that site.

Maybe reevaluate down the line and support it the future, but core support seems a little early based on those guidelines. My $0.02.

alright, i wasn't aware about those guidelines before opening this ticket.

#5 @SergeyBiryukov
10 years ago

  • Keywords reporter-feedback removed
  • Milestone 4.3 deleted
Note: See TracTickets for help on using tickets.