Changes between Version 1 and Version 2 of Ticket #32170, comment 20
- Timestamp:
- 04/28/2019 11:52:40 AM (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #32170, comment 20
v1 v2 1 1 Updated patch, first pass. I guess there are things to discuss and better practices to follow, but it's a start. Happy for any feedback and improvements. 2 2 3 To keep things simple, I've decided to don't create a new method to get additional information about sortable columns. `get_sortable_columns()` appeared to me the most logical place to add them to. This way, the new information will be available also in `get_column_info()` where there's already a filter that custom post types and custom taxonomies can use to add their own things. See screenshot:3 To keep things simple, I've decided to not create a new method to get additional information about sortable columns. `get_sortable_columns()` appeared to me the most logical place to add them to. This way, the new information will be available also in `get_column_info()` where there's already a filter that custom post types and custom taxonomies can use to add their own things. See screenshot: 4 4 5 5 [[Image(https://cldup.com/q_bJc33x0S.png)]] 6 6 7 Added a new method `print_table_description()` (similar to `print_column_headers()`, there's a bit of repetition in the code here) to print out the table information. For now, the new info are visible for testing purposes right before the tables,we'll hide them with `screen-reader-text`.7 Added a new method `print_table_description()` (similar to `print_column_headers()`, there's a bit of repetition in the code here) to print out the table information. For now, the new info is visible for testing purposes right before the tables, maybe we'll hide them with `screen-reader-text`. 8 8 9 9 About header links, couldn't find any clean way to add orderby and asc/desc feedback and at the same time to avoid that being read out when navigating through the table cells. Open to any suggestions. I'm tempted to just keep the plain links and add some hint in the table description, something like: "Activate the table header links to change order." Accessibility team, any thoughts? … … 21 21 Table ordered by Date. Descending order. <-- `aria-describedby` 22 22 row 1 column 1 23 Select All check 23 Select All checkbox not checked 24 24 column 2 25 25 link Title