WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#32173 closed enhancement (fixed)

Add support for `i` parameter in Press This

Reported by: stephdau Owned by: azaozz
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Press This Keywords: has-patch
Focuses: Cc:

Description

I was browsing the Codex page for Press This (https://codex.wordpress.org/Press_This#Technical_Note), and I noticed that there was a documented data param that wasn't replicated in the new version: i, to pass an image URL.

The attached patch enables that parameter (GET and POST), and offers the image to the user for selection (no auto-embed).

Attachments (3)

32173.diff (1.3 KB) - added by stephdau 7 years ago.
32173.2.diff (637 bytes) - added by azaozz 6 years ago.
32173.3.diff (646 bytes) - added by azaozz 6 years ago.

Download all attachments as: .zip

Change History (11)

#1 @Michael Arestad
7 years ago

Is this necessary?

@stephdau
7 years ago

#2 @stephdau
7 years ago

It's definitely something that can be leveraged by 3rd-parties to integrate with PT at a basic level, and supposedly was there.

#3 @kraftbj
7 years ago

Chatter about this feature and to include it or not: https://wordpress.slack.com/archives/core-pressthis/p1430255033001395

#4 @johnbillion
6 years ago

  • Version changed from trunk to 4.2

@azaozz
6 years ago

#5 @azaozz
6 years ago

  • Milestone changed from Awaiting Review to 4.3

Perhaps we can add the extra image src at the bottom in merge_or_fetch_data(), prepending it to the existing array so it is shown as first choice. Seems a bit simpler, see 32173.2.diff.

#6 follow-up: @obenland
6 years ago

It should be $_REQUEST['i'] rather than $_REQUEST('i').

Let's get this moving quickly, beta is only two weeks away.

@azaozz
6 years ago

#7 in reply to: ↑ 6 @azaozz
6 years ago

Replying to obenland:

Thanks for testing/catching the typo :) Fixed in 32173.3.diff.

#8 @azaozz
6 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 32936:

Press This: support passing i parameter to add an image src.
Props stephdau, azaozz. Fixes #32173.

Note: See TracTickets for help on using tickets.