#3218 closed defect (bug) (duplicate)
submenu style
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 2.1 |
Component: | Administration | Keywords: | has-patch has-unit-tests |
Focuses: | Cc: |
Description
FF screengrab attached.
(This might be a dupe - couldn't find it, though)
Attachments (1)
Change History (19)
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
7 years ago
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
6 years ago
This ticket was mentioned in Slack in #core-editor by nrqsnchz. View the logs.
4 years ago
This ticket was mentioned in PR #3254 on WordPress/wordpress-develop by andrewserong.
2 years ago
#7
- Keywords has-patch added
❗ BLOCKED by #3218 (that PR will output the layout styles generated by this PR)
This PR is a follow-up to https://github.com/WordPress/wordpress-develop/pull/3205 and backports the remaining parts of the layout block support.
## To-do
- Backport tests
- Ensure it's working on top of #3218
Trac ticket:
andrewserong commented on PR #3254:
2 years ago
#8
@tellthemachines I believe this one is working correctly — it just depends on https://github.com/WordPress/wordpress-develop/pull/3218 in order for the generated styles to be output.
This ticket was mentioned in PR #3262 on WordPress/wordpress-develop by andrewserong.
2 years ago
#9
- Keywords has-unit-tests added
This is another fork of #3218, to attempt to fix the tests that are broken in #3259.
Original PR desc:
Backporting changes to script-loader that enqueue block support styles stored by the style engine/
See tracking issue: https://github.com/WordPress/gutenberg/issues/43440
Backporting the following changes
Trac ticket:
andrewserong commented on PR #3254:
2 years ago
#10
Thanks for all the feedback @costdev! I believe I've implemented it all, so this should be ready for another look now 🙂
andrewserong commented on PR #3254:
2 years ago
#11
Alrighty, now that https://github.com/WordPress/wordpress-develop/pull/3273 has landed, it looks like this one should be good to commit now CC: @ockham
andrewserong commented on PR #3262:
2 years ago
#12
Closing now that https://github.com/WordPress/wordpress-develop/pull/3273 has landed instead.
andrewserong commented on PR #3254:
2 years ago
#13
I've given this a rebase, and confirmed that it's still working correctly on top of trunk
👍
hellofromtonya commented on PR #3254:
2 years ago
#14
I'm self-assigning for review and commit.
2 years ago
#15
## Test Report
### Steps to Test
- Apply the PR.
- Activate the Twenty Twenty-Two theme. Ensure that there are no header customizations in the Site Editor.
- Navigate to the frontend.
- Inspect the header row.
### Expected Results
- ✅ The element should now have the
.is-layout-flex
class. - ✅ The styling should match that shown in the screenshot in the PR's description.
### Environment
- Server: Apache (Linux)
- WordPress: 6.1-alpha-53344-src
- Browser: Chrome 105.0.0.0
- OS: Windows 10
- Theme: Twenty Twenty-Two
- Plugins: None activated.
### Actual Results
- ✅ The element has the
.is-layout-flex
class. - ✅ The styling matches that shown in the screenshot in the PR description.
hellofromtonya commented on PR #3254:
2 years ago
#16
For this backport, I'll be reverting the DocBlock changes for wp_get_layout_style()
. Why?
- They were not part of the backports from Gutenberg's PR 40875 https://github.com/WordPress/gutenberg/pull/40875.
- And they were introduced in 5.9.
Instead, I'll do a follow-up coding standards commit to improve the DocBlock including updating the descriptions for the optional parameters (e.g. adding the word Optional.
and adding the default Default is null.
).
hellofromtonya commented on PR #3254:
2 years ago
#17
Committed via changeset https://core.trac.wordpress.org/changeset/54274. Thank you everyone for your contributions!
A follow-up commit is coming to address other changes that were not part of the original GB PR (such as DocBlock improvements).
hellofromtonya commented on PR #3254:
2 years ago
#18
DocBlock improvements suggestioned in this PR were committed via changeset https://core.trac.wordpress.org/changeset/54275.
Duplicate of #3149, and it has a patch.