WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#32193 reopened defect (bug)

Large (custom) resolution emoticons are being shrunk to 12x12

Reported by: justatest47 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.2
Component: Formatting Keywords:
Focuses: Cc:

Description

I don't know what's different from the latest version of 4.1 to 4.2 but you guys messed with the emoticons in 4.2 and I'm really angry about it!

Now I have custom resolution emoticons being shrunk to 12x12!

For example my 40x18 emoticon is now being displayed/scaled as 12x12... imagine how it looks! Before the 4.2 series, the custom emoticons were shown as they were! At normal standard resolution so please fix this ASAP!

Change History (11)

#1 @johnbillion
3 years ago

  • Summary changed from Large (custom) resolution emoticons are being shrunk to 15x15!!!!!!!!!!! to Large (custom) resolution emoticons are being shrunk to 15x15

#2 @justatest47
3 years ago

  • Summary changed from Large (custom) resolution emoticons are being shrunk to 15x15 to Large (custom) resolution emoticons are being shrunk to 12x12

#3 @dMpmJ
3 years ago

  • Resolution set to invalid
  • Status changed from new to closed

@joostdevalk understands the inner workings of that js. he has commit rights on webkit. he says new emojis are perfect. The end.

#4 @pento
3 years ago

  • Component changed from Comments to Formatting
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Version changed from 4.2.1 to 4.2

@dMpmJ: Please don't close tickets until we've gotten to the bottom of the problem.

@justatest47: Could you please post a sample of the code you're using to add your custom emoticons, as well as a copy of at least one of them? That way we can hopefully reproduce the problem you're describing.

#5 @joostdevalk
3 years ago

This is not what I was referencing @dMpmJ :)

Optimizations are always possible, I just think the people screaming about the script being added are being daft :)

#6 follow-up: @justatest47
3 years ago

@pento: thank you for reopening my ticket! I was really sad and disappointed when I saw dMpmJ's message which basically told me to shut up and accept everything as is because he knows better... pento, you and people like you are the reason why Wordpress is so wonderful! I don't use a specific code to add custom emoticons. I just have an old plugin called Custom Smilies version 2.9.2 which hasn't been updated in years. The issue is not however with the plugin because it has worked flawlessly for years up until Wordpress 4.2 and 4.2.1. Now basically what I did was to add new custom emoticons and reupload and overwrite the already existing emoticons found here: /wp-includes/images/smilies with my own emoticons after each and every Wordpress update. So I had like a total of 40 emoticons. 22 of them had the same file names with the default ones (icon_arrow.gif, icon_biggrin.gif, etc) but different custom resolutions such as 40x18 for example, which I had to replace after every WP update, plus some 18 other emoticons with different file names uploaded by me which of course never got replaced after WP updates because they had different file names.

Anyway in short, my custom resolution emoticons are now shrunk to 12x12 and that makes them hideous. They look really bad. Especially those 40x18 ones... Is there a way to stop this from happening? Like deleting a .js file after each and every future WP update for example? Or maybe you guys will be so nice to fix this in your future updates so that I won't have to do that instead?

@joostdevalk to my understanding of what dMpmJ said in his message, its you who came up with this "wonderful" emoticon update? No disrespect to you and your work but you can't possibly think that everyone needs this. Whats the purpose of this to begin with?? What good does it do to enforce a fixed resolution of 12x12, instead of allowing them to have free custom resolutions??? If the emoticon files are 12x12 then they will be shown as such and if they are 100x30 then let them display as such. Its as simple as that! This is only a limitation which has no use whatsoever and you want people like me to accept it just because you think its useful. Anyway its not my decision and WP is not a democracy where I can decide if this is good or not. It will probably remain as is, so instead of arguing about it and its usefulness, at least please show me a way to deactivate or delete this "wonderful" javascript that keeps forcing my custom resolution emoticons to show up as 12x12.

Thank you

Last edited 3 years ago by justatest47 (previous) (diff)

#7 in reply to: ↑ 6 ; follow-up: @SergeyBiryukov
3 years ago

Replying to justatest47:

please show me a way to deactivate or delete this "wonderful" javascript that keeps forcing my custom resolution emoticons to show up as 12x12.

Try https://wordpress.org/plugins/disable-emojis/.

#8 in reply to: ↑ 7 ; follow-up: @justatest47
3 years ago

Replying to SergeyBiryukov:

Replying to justatest47:

please show me a way to deactivate or delete this "wonderful" javascript that keeps forcing my custom resolution emoticons to show up as 12x12.

Try https://wordpress.org/plugins/disable-emojis/.

Interesting! That was fast! Is there another way to do that without using a plugin? I hate having to install too many plugins because they use hardware resources and I try to keep it as minimal as I can.

Update: Ok I've just tried this plugin and it doesn't help at all. All my emoticons are still being shrunk to 12x12 :(( Someone please help me, this is driving me nuts.

Thanks

Last edited 3 years ago by justatest47 (previous) (diff)

#9 @justatest47
3 years ago

I actually just had an idea! Somewhere in settings, perhaps in Discusion, add a new checkbox with this name "Enable Emojis for comments". If left unchecked this will disable the new emoji emoticons which messes up with custom sized emoticons.

What do you guys think? Could you implement this in the future 4.2.2 update? Please? I doubt I'm the only one who wants this. Disable Emojis already has 800+ installs which means 800 people who KNEW about this wanted it disabled. Imagined how many more are upset by this but don't even know how this is called, let alone find a way to disable it.

#10 in reply to: ↑ 8 ; follow-up: @SergeyBiryukov
3 years ago

Replying to justatest47:

Is there another way to do that without using a plugin? I hate having to install too many plugins because they use hardware resources and I try to keep it as minimal as I can.

The plugin only contains a few lines to disable emoji scripts and styles, it should not have any significant impact on server resources.

I don't think there'll be a UI option for disabling emoji, it would go against the "Decisions, not options" principle.

#11 in reply to: ↑ 10 @justatest47
3 years ago

Replying to SergeyBiryukov:

Replying to justatest47:

Is there another way to do that without using a plugin? I hate having to install too many plugins because they use hardware resources and I try to keep it as minimal as I can.

The plugin only contains a few lines to disable emoji scripts and styles, it should not have any significant impact on server resources.

I don't think there'll be a UI option for disabling emoji, it would go against the "Decisions, not options" principle.

I have already tested your suggested plugin but it does not work. My WP still shrinks emoticons. I totally agree on not changing the UI at all but then again you can't continue to add new features, remove old ones, change old ones, etc without touching the UI at all. Not touching the UI would only work in case WP updates would be only about fixing bugs, security flaws and not adding new features.... Adding new features (such as emojis) should always be accompanied by a new option to configure/enable/disable that NEW FUNCTION, a small UI change.

Anyway the thing is that I still didn't fix my problem. The plugin you suggested does nothing for me. My emoticons are still being affected.

Thanks

Note: See TracTickets for help on using tickets.