WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#32203 closed enhancement (fixed)

Update Twemoji to 1.4.1

Reported by: azaozz's profile azaozz Owned by: azaozz's profile azaozz
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: External Libraries Keywords:
Focuses: Cc:

Description

Was released few days ago (2015-04-23). Has several fixes and improvements, most importantly implements a callback function for the replacement image attributes.

Currently we pass an object to set additional attributes when using Twemoji inside the editor. This needs to be updated to use the new callback.

Change History (5)

#1 @obenland
10 years ago

  • Owner set to azaozz
  • Status changed from new to assigned

#2 @obenland
9 years ago

@azaozz, what's the status? Do you still want to do this or should we wait until 4.4 and a new Twemoji version?

#3 @azaozz
9 years ago

There are few fixes in twemoji.js that we need, the last one was just added yesterday.

Generally we should update external libraries before beta. If there are fixes that affect WordPress bugs, we can update during beta too.

#4 @obenland
9 years ago

Works for me. I'll bug you again next week then (if this ticket is still open).

#5 @azaozz
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32959:

Update Twemoji to 1.4.1 including up to ​https://github.com/twitter/twemoji/commit/3c0c13d3a53ba9611098ca867565e7751449adfa (exclude SVG elements). Remove our hacks and adapt wp-emoji.js to use the new image attributes callback.
Fixes #32203.

Note: See TracTickets for help on using tickets.