Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#32210 closed defect (bug) (fixed)

Bulk Edit: post format missing label

Reported by: afercia's profile afercia Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Quick/Bulk Edit Keywords: has-patch
Focuses: ui, accessibility Cc:

Description

When bulk editing posts, if the active theme supports Post Formats there will be also a "Format" select which misses the required id to be targeted by the label for attribute.

Attachments (1)

32210.patch (775 bytes) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (5)

@afercia
9 years ago

#1 @SergeyBiryukov
9 years ago

  • Component changed from Administration to Quick/Bulk Edit
  • Milestone changed from Awaiting Review to 4.3

#2 @afercia
9 years ago

  • Keywords has-patch added

In the proposed patch:

  • Bulk Edit: properly associate the Post Formats select with its label

Screenshot with patch applied:

https://cldup.com/nYNOjofUuG.png

#3 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 32329:

Bulk Edit: Properly associate the Format select with its label.

props afercia.
fixes #32210.

#4 @afercia
9 years ago

For future reference: the patch uploaded here was wrong, the correct fix was to actually remove the for="post_format" attribute as @SergeyBiryukov pointed out, see his commit :)

Note: See TracTickets for help on using tickets.