WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#32213 closed defect (bug) (fixed)

Semantic elements for non-link links: Quick Edit and Bulk Edit

Reported by: afercia Owned by: afercia
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Quick/Bulk Edit Keywords: has-patch commit semantic-buttons
Focuses: ui, accessibility Cc:

Description

In the Quick Edit form:

  • the "Cancel" and "Update" button are currently links that look like buttons

In the Bulk Edit form:

  • same but just for the "Cancel" button

For semantics and accessibility, they all should be buttons. See related #26504.

Attachments (1)

32213.patch (1.7 KB) - added by afercia 6 years ago.

Download all attachments as: .zip

Change History (9)

@afercia
6 years ago

#1 @afercia
6 years ago

  • Keywords has-patch added

In the proposed patch:

  • Quick Edit and Bulk Edit: make the Cancel and Update buttons real buttons

To quickly check without the need to install a screen reader, you can apply the patch and test the buttons can now be activated pressing Spacebar on your keyboard.

Last edited 6 years ago by afercia (previous) (diff)

#2 @afercia
6 years ago

Thinking a screenshot would be useful to make clear why buttons should be buttons :) We don't want them to be reported as "Internal link" (or "link" depending on the screen reader used). See below the ChromeVox console:

https://cldup.com/pfSsBNt8Gm.png

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


6 years ago

#4 @afercia
5 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Owner set to afercia
  • Status changed from new to assigned

#5 @afercia
5 years ago

  • Keywords commit added

This ticket was mentioned in Slack in #design by stephdau. View the logs.


5 years ago

#7 @wonderboymusic
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32869:

Use <button> instead of <a> for non-link links in Quick Edit.

Props afercia.
Fixes #32213.

#8 @afercia
4 years ago

  • Keywords semantic-buttons added
Note: See TracTickets for help on using tickets.