WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#32218 closed enhancement (fixed)

Hide the title attribute option by default in Menu Editor

Reported by: mor10 Owned by: helen
Milestone: 4.3 Priority: low
Severity: normal Version:
Component: Menus Keywords: has-patch
Focuses: ui, accessibility, administration Cc:
PR Number:

Description

The arguments for removing the title attribute from regular links also apply to the menu editor. I would venture to guess the argument that "nobody uses the feature" applies here more than it does for regular links.

For consistency across the UI the option should be removed.

Alternately it should be hidden by default and only made visible if the user activates it from the Screen Options panel.

Attachments (2)

32218.1.diff (1.4 KB) - added by peterwilsoncc 4 years ago.
32218.diff (1.9 KB) - added by paulwilde 4 years ago.

Download all attachments as: .zip

Change History (13)

#1 @peterwilsoncc
4 years ago

  • Type changed from defect (bug) to enhancement

What would be appropriate for legacy settings in this instance?

  • Remove it from all installs
  • Remove the field from new installs only
  • Remove the field if the title is empty/matches the navigation label

Uploaded file removes the setting from all installs, displays it in the front end if the legacy setting isn't empty. I suspect it's too blunt an instrument.

#2 @DrewAPicture
4 years ago

  • Focuses accessibility added

#3 @odie2
4 years ago

Oposite to completely remove.
I am using it in some cases and it's very usefull, especially if menu is just simpler container instead of custom post types. For example custom slider.
Could be hidden by default, but no removed.

#4 @johnbillion
4 years ago

  • Keywords needs-patch added
  • Priority changed from normal to low
  • Version trunk deleted

My preference is to make the "Navigation Label" and "Title Attribute" fields full-width, add the title attribute field to Screen Options, and make it hidden by default.

Unlike regular links, there's no easy way to add a title attribute to a menu item so we shouldn't outright remove this functionality.

@paulwilde
4 years ago

#5 @paulwilde
4 years ago

  • Keywords has-patch added; needs-patch removed

I've added a patch which does everything that johnbillion mentioned above.

#6 @helen
4 years ago

  • Milestone changed from Awaiting Review to 4.3

I'm into it.

#7 @celloexpressions
4 years ago

Menu Customizer has done this for about the past year - screen-optional and off by default :). So, if it does make it into 4.3 we can probably consider this fixed on account of the Menus page being effectively slated for removal for a vast majority of users within a few releases as the Customizer is emphasized further for all of the old "Appearance" things. I'm not opposed to back-porting it here, but I wouldn't spend much time on it. The menus screen in the admin is just so fundamentally flawed in architecture that I don't see us giving it much work at all once menus are available in the Customizer.

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


4 years ago

#9 @rianrietveld
4 years ago

The a11y team is discussing all 4.3 accessibility tickets. We want to clean our to do list and get everything fixed. What do we do with this ticket? If the patch is ok it can be committed, if it's to much trouble, or not worth it, the ticket should be closed.

#10 @helen
4 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 32691:

Nav menus: hide the title attribute field by default for new users and installs.

It is still available in screen options. This also gives the "Navigation Label", a crucial field, the room it really deserves.

props paulwilde.
fixes #32218.

#11 in reply to: ↑ description @SergeyBiryukov
4 years ago

  • Summary changed from Remove title attribute option in Menu Editor to Hide the title attribute option by default in Menu Editor

Replying to mor10:

The arguments for removing the title attribute from regular links also apply to the menu editor. I would venture to guess the argument that "nobody uses the feature" applies here more than it does for regular links.

Someone made a point to me that although WordPress now discourages using the title attribute in regular links, WordPress.org still uses it in header menu, which could be perceived as double standards.

I don't think the same arguments apply here, because menu items need to be succinct and can only contain one or two words, whereas regular link text in post content can be as long as needed.

Last edited 4 years ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.