WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#32227 closed defect (bug) (fixed)

Customizer: remove Header Image button should be a button

Reported by: afercia's profile afercia Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Customize Keywords: has-patch
Focuses: ui, accessibility Cc:

Description

For semantics and keyboard accessibility, UI controls should use ​elements that have native support for keyboard interaction. In this case, a simple <button> with a proper screen-reader-text text will make this control usable and accessible.

About styling, see related #31325.

Attachments (2)

32227.patch​ (1.7 KB) - added by afercia 9 years ago.
32227.2.diff​ (1.7 KB) - added by RDall 9 years ago.
Combines patches 32227 and 31325 into one file as per Jorbin's request

Download all attachments as: .zip

Change History (7)

@afercia
9 years ago

#1 @afercia
9 years ago

  • Keywords has-patch added

In the proposed patch:

  • Customizer: use a semantic, accessible element for the Header Image remove button

About the styling part, we should wait for #31325

#2 @jorbin
9 years ago

  • Milestone changed from Awaiting Review to 4.3

This ticket was mentioned in ​Slack in #core by ocean90. ​View the logs.
9 years ago

@RDall
9 years ago

Combines patches 32227 and 31325 into one file as per Jorbin's request

This ticket was mentioned in ​Slack in #core by rdall. ​View the logs.
9 years ago

#5 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 32382:

Customizer: Use a semantic, accessible element for Remove Header Image button.

Make the button more noticeable on dark, light, and busy images.

props afercia, RDall, melchoyce.
fixes #32227, #31325.

Note: See TracTickets for help on using tickets.