WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 6 months ago

#32238 new enhancement

Enhancement has_filter function

Reported by: tuanphp Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.2.1
Component: Plugins Keywords: has-patch
Focuses: Cc:
PR Number:

Description

I am optimize has_filter wordpress function. It is simple logic.

Code here: http://pastebin.com/mW0tBstE

I cannot create a path file. So I create this ticket. Hope someone will accepted that.

Attachments (3)

#32238.patch (1.9 KB) - added by tuanphp 5 years ago.
Enhancement logic and bug in case priority equal with zero
#32238.1.patch (1.9 KB) - added by tuanphp 5 years ago.
Fix old code too.
#32238.3.patch (1.6 KB) - added by tuanphp 5 years ago.
Fix tab convention.

Download all attachments as: .zip

Change History (8)

#1 @SergeyBiryukov
5 years ago

  • Component changed from General to Plugins
  • Keywords reporter-feedback added

Hi @tuanphp, welcome to Trac!

Could you describe your changes? See also https://make.wordpress.org/core/2011/03/23/code-refactoring/.

#2 follow-up: @Shelob9
5 years ago

@tuanphp I wrote a helpful guide to creating and submitting a patch that you mind find useful: http://code.tutsplus.com/tutorials/creating-and-submitting-a-patch-to-wordpress-core--cms-20658

#3 in reply to: ↑ 2 @tuanphp
5 years ago

Replying to Shelob9:

@tuanphp I wrote a helpful guide to creating and submitting a patch that you mind find useful: http://code.tutsplus.com/tutorials/creating-and-submitting-a-patch-to-wordpress-core--cms-20658

Thanks. I will try it.

@tuanphp
5 years ago

Enhancement logic and bug in case priority equal with zero

@tuanphp
5 years ago

Fix old code too.

#4 @tuanphp
5 years ago

  • Keywords has-patch added; reporter-feedback removed

#5 @rmccue
5 years ago

Looks like your patch accidentally changes tabs to spaces, note that all WP code uses tabs for indentation. Can you reformat with the indentation corrected please? :)

(If you can't, we can correct it for you, but probably good to fix it now in case you want to make future patches too. :) )

@tuanphp
5 years ago

Fix tab convention.

Note: See TracTickets for help on using tickets.