/theme-compat/header.php loads images from Kubrick in header, causing 404s if not using Kubrick

[Shelob9]

This issue is super edge case, but using get_header() is not deprecated, so I am reporting.

In /theme-compat/header.php there is some inline CSS in a conditional that will output:
/images/kubrickbg-<?php bloginfo('text_direction'); ?>.jpg or #page { background: url("<?php bloginfo('stylesheet_directory'); ?>/images/kubrickbgwide.jpg") repeat-y top; border: none; }. This assumes your current theme has the same image directory as kubrick does, and if it doesn't causes a 404 error when the browser tries to load the image.

[obenland]

Nice find. Yes, I suppose a check if Kubrick is the current theme can't hurt.

[Shelob9]

@obenland Wouldn't it make more sense to do a file_exists() check?

[Mte90]

I want to try with this ticket as my first bug.
i think that the better solution is check the theme, check for the file is not a good idea for performance.
how i can simulate this bug? what is the theme for use this file?

[Mte90]

I think that for fix this the solution is replace the 27 line of theme-compat/header.php with

if ( wp_get_theme() !== 'Default' && empty($withcomments) && !is_single() ) {

[Shelob9]

@Mte90 No theme should be doing this, but if you create a theme without a header.php file, and then use get_header() it will pull in the /theme-compat/header.php file, which has references to image files that are in the Kubrick theme.

My problem with checking if Kubrick is the theme is that you can't do so reliably. get_stylesheet() is effectively a reference to the name of the directory that contains the active theme. If I install Kubrick in a directory called hats, then get_stylesheet() will return hats, not Kubrick, even though I'm using Kubrick.

In my opinion, the only reliable way to fix this issue, is to use a file_exists() or similar for 3 reasons:
1) The reason I just gave.
2) If Kubrick is in use, the file still could have been deleted.
3) A theme besides Kubrick could have that file in it, and be counting on it.

[Mte90]

with your explanation I think you're right. Someone can assign to me as a first good bug?

[Mte90]

This patch check if the file exist for print the style tag

[johnbillion]

Thanks for the patch Mte90. All that needs correcting is the file_exists() check should use get_stylesheet_directory() instead of get_template_directory(), as that's what's used in the image URL in the CSS.

[Mte90]

patch updated with the suggestion

[johnbillion]

Fixed in r32496