WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #32248, comment 10


Ignore:
Timestamp:
07/04/2015 04:23:44 AM (5 years ago)
Author:
matthewmi11er
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #32248, comment 10

    v1 v2  
    1 I think the change to '''get_terms()''' fixes the error in the specific circumstances list in the original issue description. However what may be happening (if I'm tracing everything properly) is that '''wp_set_post_terms()''' is called twice when updating the post. The first time the term name is passed to it, which fails to update the tags properly. The second time the term_id is passed which succeeds.
     1I think the change to '''get_terms()''' fixes the error in the specific circumstances listed in the original issue description. However what may be happening (if I'm tracing everything properly) is that '''wp_set_post_terms()''' is called twice when updating the post. The first time the term name is passed to it, which fails to update the tags properly. The second time the term_id is passed which succeeds.
    22
    33Moving this to a new issue may make sense (I'd be fine with that). I don't have a specific demonstration but I think it will show up anywhere '''wp_set_object_terms()''' gets called with the term name (instead of terrm_id) and the term name has an ampersand and the slug has been modified.