WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#32255 closed defect (bug) (fixed)

List Table: media wp-list-table lacks table header content for column-icon

Reported by: rianrietveld Owned by: afercia
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.1
Component: Administration Keywords: has-patch
Focuses: ui, accessibility Cc:
PR Number:

Description

In wp-admin/upload.php wp-list-table the <th> for the image/file (column-icon) has no content:

http://www.rianrietveld.com/wp-content/uploads/2015/05/media-edit.png

<tr>
<th scope="col" id="cb" class="manage-column column-cb check-column" style="">
  <label class="screen-reader-text" for="cb-select-all-1">Select All</label>
  <input id="cb-select-all-1" type="checkbox">
</th>
<th scope="col" id="icon" class="manage-column column-icon" style=""></th>
<th scope="col" id="title" class="manage-column column-title sortable desc" style="">
  <a href=".../wp-admin/upload.php?orderby=title&amp;order=asc">
    <span>File</span><span class="sorting-indicator"></span>
  </a>
</th>

etc ...

Suggestions:

  • Add as content for the column-icon: "File"
  • Change the content for column-title into: "Title". This would be consistent with the other list tables in the admin

Attachments (1)

32255.diff (759 bytes) - added by pareshradadiya 5 years ago.

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


5 years ago

@pareshradadiya
5 years ago

#2 @pareshradadiya
5 years ago

  • Keywords has-patch added

#3 @joedolson
5 years ago

I think this is a good solution.

#4 @joedolson
5 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Owner set to afercia
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core by joedolson. View the logs.


5 years ago

#6 @joedolson
5 years ago

  • Keywords commit added

#7 follow-up: @obenland
5 years ago

  • Keywords commit removed

I'm pretty sure the lack of heading stems from the variety of content of that column. For images it shows a preview, and "File" would make sense because you can see the content of the file. For everything else it uses icons to represent the file, and "File" would probably not really fit anymore.

Does the lack of a title present an actual problem somewhere or is this more of a cosmetic change?

#8 in reply to: ↑ 7 @afercia
5 years ago

Replying to obenland:

Does the lack of a title present an actual problem somewhere or is this more of a cosmetic change?

The problem here is it's a TH but there's no text to be read as column header. We should add some text or, maybe, this shouldn't be a TH but just a TD. By the way, this ticket should be considered together with #32254 if we end up hiding the linked thumbnails/icons from assistive technologies, maybe there's no point in adding the missing header text.

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


5 years ago

#10 @afercia
5 years ago

Screenshot before and after applying the patch:

https://cldup.com/VOTzP0QGCo.png

Maybe we could hide the header text with screen-reader-text in order to avoid a visual change and related discussions and maybe use something better than "File" as text. Should be something that covers also the cases of media being Audio, Video, documents, and any allowed media type.

Side note: changing the current "File" header text in "Title" would also encourage users to provide an actual Title for all media, with benefits for the alt-caption-title fallback see related #18984

#11 @afercia
5 years ago

Related: #32509

#12 @afercia
5 years ago

Related: #29993 maybe the thumbnail column will be removed.

#13 @helen
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32687:

Media: move the thumbnail into the title column in list view.

This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.

props bradt for the initial patch.
fixes #29993 and #32255. see #32509 and #32395.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.