Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#32259 closed defect (bug) (fixed)

Quick Edit: password field disabled for non private posts

Reported by: afercia's profile afercia Owned by: obenland's profile obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Quick/Bulk Edit Keywords: has-patch commit
Focuses: ui, javascript Cc:

Description

Edge case but can break your work flow. To reproduce:

  • "Quick Edit" a private post
  • the password field is correctly disabled
  • edit something and save or just Cancel
  • now "Quick Edit" a non-private post
  • the password field is still disabled

See screenshot below. You have to check the "Private" checkbox and then un-check it to re-enable the Password field.

The Quick Edit form is cloned and then populated with specific Post data via JavaScript so in the first step the password field gets a "disabled" attribute. But then the disabled attribute should be updated accordingly with the "private" status of following Posts being edited.

https://cldup.com/Tq38RTgAQi.png

Attachments (2)

32259.patch (1.1 KB) - added by afercia 9 years ago.
32259.2.patch (1.1 KB) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (7)

@afercia
9 years ago

#1 @afercia
9 years ago

  • Keywords has-patch added

In the proposed patch:

  • Quick Edit: update the Password field disabled attribute accordingly to each post private status

#2 @afercia
9 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Owner set to afercia
  • Status changed from new to assigned

@afercia
9 years ago

#3 @afercia
9 years ago

  • Keywords commit added

Updated patch with coding standards.

#4 @obenland
9 years ago

  • Owner changed from afercia to obenland
  • Status changed from assigned to accepted

#5 @obenland
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 32716:

When inline editing a post, reset password field to be editable by default.

The Quick Edit form is cloned and then populated with post-specific data. If the
previous post was private, the password field would continue to be disabled for
the next post.

Props afercia.
Fixes #32259.

Note: See TracTickets for help on using tickets.