WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#32260 closed defect (bug) (fixed)

YouTube oEmbeds always return HTTPS iframe src, breaking unit test

Reported by: boonebgorges's profile boonebgorges Owned by: boonebgorges's profile boonebgorges
Milestone: 4.2.2 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: fixed-major
Focuses: Cc:

Description

See #23149, [26978]. test_youtube_com_secure_embed() expects an oEmbed request for an http:// video URL to return an iframe containing an http:// src attribute. At some point in the last week (based on travis-ci build history), youtube.com changed their behavior so that all oEmbed requests return an iframe whose src is a secure https:// URL. See eg ​http://www.youtube.com/oembed?url=http://www.youtube.com/watch?v=oHg5SJYRHA0. The test should be updated accordingly.

Change History (3)

#1 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 32358:

youtube.com oEmbed test should always expect HTTPS.

YouTube recently changed its oEmbed endpoint so that the iframe markup always
contains an HTTPS URL, regardless of the scheme of the video URL originally
requested. This changeset fixes the corresponding unit test.

Fixes #32260.

#2 @pento
10 years ago

  • Keywords fixed-major added
  • Milestone changed from 4.3 to 4.2.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening for backport to 4.2 branch, so that unit tests aren't failing in the current stable branch.

We don't need to worry about backporting it further.

#3 @pento
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 32365:

youtube.com oEmbed test should always expect HTTPS.

YouTube recently changed its oEmbed endpoint so that the iframe markup always contains an HTTPS URL, regardless of the scheme of the video URL originally requested. This changeset fixes the corresponding unit test.

Props boonebgorges.

Fixes #32260.

Note: See TracTickets for help on using tickets.